From: Ingo Molnar <mingo@elte.hu>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, jgarzik@pobox.com,
netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, alan@redhat.com
Subject: [patch, -rc5-mm1] lock validator: remove softirq.c WARN_ON
Date: Tue, 30 May 2006 13:55:45 +0200 [thread overview]
Message-ID: <20060530115545.GA7025@elte.hu> (raw)
In-Reply-To: <447C261E.1090202@gmail.com>
* Jiri Slaby <jirislaby@gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Andrew Morton napsal(a):
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm1/
>
> BUG: warning at /l/latest/xxx/kernel/softirq.c:86/local_bh_disable()
ok, that WARN_ON is over-eager. Fix is below:
--------------
Subject: lock validator: remove softirq.c WARN_ON
From: Ingo Molnar <mingo@elte.hu>
there is nothing wrong with calling local_bh_disable() in irqs-off
section (as long as the local_bh_enable isnt done with irqs-off),
so remove this over-eager WARN_ON().
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
kernel/softirq.c | 1 -
1 file changed, 1 deletion(-)
Index: linux/kernel/softirq.c
===================================================================
--- linux.orig/kernel/softirq.c
+++ linux/kernel/softirq.c
@@ -83,7 +83,6 @@ static void __local_bh_disable(unsigned
void local_bh_disable(void)
{
- WARN_ON_ONCE(irqs_disabled());
__local_bh_disable((unsigned long)__builtin_return_address(0));
}
next prev parent reply other threads:[~2006-05-30 11:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060530022925.8a67b613.akpm@osdl.org>
2006-05-30 11:02 ` BUG: warning at ... (netlink) [Was: 2.6.17-rc5-mm1] Jiri Slaby
2006-05-30 11:55 ` Ingo Molnar [this message]
2006-05-30 16:00 ` [patch, -rc5-mm1] lock validator: remove softirq.c WARN_ON Alexey Kuznetsov
2006-05-30 16:05 ` Arjan van de Ven
2006-05-30 16:15 ` Alexey Kuznetsov
2006-05-30 15:59 ` 2.6.17-rc5-mm1 Michal Piotrowski
2006-05-30 16:08 ` 2.6.17-rc5-mm1 Arjan van de Ven
2006-05-30 18:51 ` 2.6.17-rc5-mm1 Michal Piotrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060530115545.GA7025@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=jgarzik@pobox.com \
--cc=jirislaby@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).