From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn
Date: Wed, 31 May 2006 19:31:14 +0200
Message-ID: <200605311931.17910.IvDoorn@gmail.com>
References: <200605251716.00742.IvDoorn@gmail.com> <200605291758.07930.IvDoorn@gmail.com> <20060530214305.GA27891@electric-eye.fr.zoreil.com>
Mime-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart4459744.32pHPmUK6x";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from nf-out-0910.google.com ([64.233.182.189]:49295 "EHLO
	nf-out-0910.google.com") by vger.kernel.org with ESMTP
	id S1751753AbWEaR2a (ORCPT <rfc822;netdev@vger.kernel.org>);
	Wed, 31 May 2006 13:28:30 -0400
Received: by nf-out-0910.google.com with SMTP id o25so144334nfa
        for <netdev@vger.kernel.org>; Wed, 31 May 2006 10:28:29 -0700 (PDT)
To: Francois Romieu <romieu@fr.zoreil.com>
In-Reply-To: <20060530214305.GA27891@electric-eye.fr.zoreil.com>
Sender: netdev-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

--nextPart4459744.32pHPmUK6x
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 30 May 2006 23:43, Francois Romieu wrote:
> Ivo van Doorn <ivdoorn@gmail.com> :
> [...]
> > diff --git a/drivers/input/misc/radiobtn.c b/drivers/input/misc/radiobt=
n.c
> > new file mode 100644
> > index 0000000..8d3b84a
> > --- /dev/null
> > +++ b/drivers/input/misc/radiobtn.c
> [...]
> > +void radiobtn_poll(unsigned long data)
>=20
> static ?

Good point. Will fix this immediately.

> [...]
> > +int radiobtn_register_device(struct radio_button *radiobtn)
> > +{
> > +	int status;
> > +
> > +	/*
> > +	 * Check if all mandatory fields have been set.
> > +	 */
> > +	if (radiobtn->poll_delay =3D=3D 0 || radiobtn->button_poll =3D=3D NUL=
L)
> > +		return -EINVAL;
> > +
> > +	/*
> > +	 * Allocate, initialize and register input device.
> > +	 */
> > +	radiobtn->input_dev =3D input_allocate_device();
> > +	if (!radiobtn->input_dev) {
> > +		printk(KERN_ERR "Failed to allocate input device %s.\n",
> > +			radiobtn->dev_name);
> > +		return -ENOMEM;
> > +	}
> > +
> > +	radiobtn->input_dev->name =3D "Radio button";
> > +	radiobtn->input_dev->phys =3D strcat("radiobtn/", radiobtn->dev_name);
>=20
> The first parameter of strcat() must be big enough to contain the whole
> string.

Will replace it with
sprintf(wrqu->name, "radiobtn/", radiobtn->dev_name);

Thanks.

Ivo

--nextPart4459744.32pHPmUK6x
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBEfdLlaqndE37Em0gRAtrxAJ9EBPRDU9UrpOYxCaPyfc9jRvBTpQCgmzuf
VHko5i3MEJHs3nrvphynNs4=
=cwnn
-----END PGP SIGNATURE-----

--nextPart4459744.32pHPmUK6x--