netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shemminger@osdl.org
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [PATCH] TCP: removal of unused label
Date: Mon, 05 Jun 2006 16:03:52 -0700 (PDT)	[thread overview]
Message-ID: <20060605.160352.21926542.davem@davemloft.net> (raw)
In-Reply-To: <20060605160240.4951f7ad@dxpl.pdx.osdl.net>

From: Stephen Hemminger <shemminger@osdl.org>
Date: Mon, 5 Jun 2006 16:02:40 -0700

> rtattr_failure is used inside __RTA_PUT() macro. It's gross, but there are
> those who love it..

Yes, it was clear that this patch wasn't build tested.

And GCC usually warns very loudly about truly unused
labels.

  reply	other threads:[~2006-06-05 23:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-05 18:03 [PATCH] TCP changes for 2.6.18 Stephen Hemminger
2006-06-05 19:55 ` [PATCH] TCP: removal of unused label Francois Romieu
2006-06-05 23:02   ` Stephen Hemminger
2006-06-05 23:03     ` David Miller [this message]
2006-06-05 23:58 ` [PATCH] TCP changes for 2.6.18 David Miller
2006-06-06 16:46   ` Stephen Hemminger
2006-06-06 19:29     ` David Miller
2006-06-06 20:13       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060605.160352.21926542.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).