From: David Miller <davem@davemloft.net>
To: akpm@osdl.org
Cc: netdev@vger.kernel.org, Jari.Takkala@Q9.com
Subject: Re: [patch 06/17] neighbour.c, pneigh_get_next() skips published entry
Date: Mon, 05 Jun 2006 16:30:36 -0700 (PDT) [thread overview]
Message-ID: <20060605.163036.102574536.davem@davemloft.net> (raw)
In-Reply-To: <200606020328.k523S8hh028820@shell0.pdx.osdl.net>
From: akpm@osdl.org
Date: Thu, 01 Jun 2006 20:32:26 -0700
> From: "Jari Takkala" <Jari.Takkala@Q9.com>
>
> Fix a problem where output from /proc/net/arp skips a record when the full
> output does not fit into the users read() buffer.
>
> To reproduce: publish a large number of ARP entries (more than 10 required
> on my system). Run 'dd if=/proc/net/arp of=arp-1024.out bs=1024'. View
> the output, one entry will be missing.
>
> Signed-off-by: Jari Takkala <jari.takkala@q9.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
This patch doesn't make any sense, I've been over it a few
times.
The seqfile layer should take care of that user buffering
issue transparently as long as we implement the interface
callbacks properly.
Even if something needs to be fixed in the pneigh dumper,
special casing *pos==1 doesn't look right. Also, if pneigh
has this problem, how come the neigh seqfile iterators don't
have the same problem or do they?
next prev parent reply other threads:[~2006-06-05 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-02 3:32 [patch 06/17] neighbour.c, pneigh_get_next() skips published entry akpm
2006-06-05 23:30 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-08 18:21 Jari Takkala
2006-06-09 4:52 ` Herbert Xu
2006-06-09 20:14 Jari Takkala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605.163036.102574536.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jari.Takkala@Q9.com \
--cc=akpm@osdl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox