From: "John W. Linville" <linville@tuxdriver.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Greg KH <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz, netdev@vger.kernel.org,
mb@bu3sch.de, st3@riseup.net
Subject: Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device
Date: Mon, 5 Jun 2006 14:56:19 -0400 [thread overview]
Message-ID: <20060605185614.GG6068@tuxdriver.com> (raw)
In-Reply-To: <4476E69F.6020502@gmail.com>
On Fri, May 26, 2006 at 01:29:12PM +0159, Jiri Slaby wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Jeff Garzik napsal(a):
> > Jiri Slaby wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Jeff Garzik napsal(a):
> >>> The point is that you don't need to loop over the table,
> >>> pci_match_one_device() does that for you.
> >> The problem is, that there is no such function, I think.
> >> If you take a look at pci_dev_present:
> >
> > The function you want is pci_dev_present().
> Nope, it returns only 0/1.
Did we get a resolution on this? I don't think Jeff is going to pull
this patch from me until you satisfy him that it is correct... :-)
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-06-05 18:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060526001053.D2349C7C58@atrey.karlin.mff.cuni.cz>
2006-05-26 0:35 ` [PATCH 2/3] pci: bcm43xx avoid pci_find_device Jeff Garzik
2006-05-26 10:20 ` Jiri Slaby
2006-05-26 10:22 ` Jeff Garzik
2006-05-26 10:33 ` Jiri Slaby
2006-05-26 10:37 ` Jeff Garzik
2006-05-26 10:54 ` Jiri Slaby
2006-05-26 11:09 ` Jeff Garzik
2006-05-26 11:30 ` Jiri Slaby
2006-06-05 18:56 ` John W. Linville [this message]
2006-06-05 19:10 ` Jiri Slaby
2006-05-26 11:49 ` Michael Buesch
2006-05-26 11:52 ` Jiri Slaby
2006-06-05 20:16 [PATCH 0/3 #3] " Jiri Slaby
[not found] ` <20060605202007.B464FC7B73@atrey.karlin.mff.cuni.cz>
2006-06-05 20:53 ` [PATCH 2/3] pci: bcm43xx " Greg KH
2006-06-05 21:09 ` Jiri Slaby
2006-06-06 1:18 ` Jeff Garzik
2006-06-06 6:50 ` Greg KH
2006-06-06 12:58 ` Michael Buesch
[not found] <20060605201818.1239938CE036@bu3sch.de>
2006-06-05 20:35 ` Michael Buesch
2006-06-05 20:46 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605185614.GG6068@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=gregkh@suse.de \
--cc=jgarzik@pobox.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
--cc=st3@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).