From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device Date: Mon, 5 Jun 2006 14:56:19 -0400 Message-ID: <20060605185614.GG6068@tuxdriver.com> References: <20060526001053.D2349C7C58@atrey.karlin.mff.cuni.cz> <44764D4B.6050105@pobox.com> <4476D63E.8090207@gmail.com> <4476D6EC.4060501@pobox.com> <4476D95B.5030601@gmail.com> <4476DA5C.9080602@pobox.com> <4476DE47.7010907@gmail.com> <4476E203.1080701@pobox.com> <4476E69F.6020502@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff Garzik , Greg KH , Linux Kernel Mailing List , linux-pci@atrey.karlin.mff.cuni.cz, netdev@vger.kernel.org, mb@bu3sch.de, st3@riseup.net Return-path: Received: from ra.tuxdriver.com ([24.172.12.4]:25097 "EHLO ra.tuxdriver.com") by vger.kernel.org with ESMTP id S1751296AbWFES5n (ORCPT ); Mon, 5 Jun 2006 14:57:43 -0400 To: Jiri Slaby Content-Disposition: inline In-Reply-To: <4476E69F.6020502@gmail.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, May 26, 2006 at 01:29:12PM +0159, Jiri Slaby wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jeff Garzik napsal(a): > > Jiri Slaby wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- > >> Hash: SHA1 > >> > >> Jeff Garzik napsal(a): > >>> The point is that you don't need to loop over the table, > >>> pci_match_one_device() does that for you. > >> The problem is, that there is no such function, I think. > >> If you take a look at pci_dev_present: > > > > The function you want is pci_dev_present(). > Nope, it returns only 0/1. Did we get a resolution on this? I don't think Jeff is going to pull this patch from me until you satisfy him that it is correct... :-) John -- John W. Linville linville@tuxdriver.com