From: Stephen Hemminger <shemminger@osdl.org>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: netdev@vger.kernel.org, meder@de.ibm.com, raisch@de.ibm.com,
themann@de.ibm.com, tklein@de.ibm.com
Subject: Re: [PATCH 3/4] ehea: queue managment
Date: Wed, 7 Jun 2006 10:29:50 -0700 [thread overview]
Message-ID: <20060607102950.54dd83c1@localhost.localdomain> (raw)
In-Reply-To: <4487073E.1020403@de.ibm.com>
On Wed, 07 Jun 2006 19:05:02 +0200
Jan-Bernd Themann <ossthema@de.ibm.com> wrote:
> Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
>
>
> drivers/net/ehea/ehea_qmr.c | 719 ++++++++++++++++++++++++++++++++++++++++++++
> drivers/net/ehea/ehea_qmr.h | 390 +++++++++++++++++++++++
> 2 files changed, 1109 insertions(+)
>
Make it look less like C++
Do you really need to use vmalloc/vfree? Are the data structures that big?
Be careful about global namespace issues. Stick to one prefix like ehea_
for all non static function names. Consider putting all in one file, or
use #include to cause it to be one compilation unit.
next prev parent reply other threads:[~2006-06-07 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 17:05 [PATCH 3/4] ehea: queue managment Jan-Bernd Themann
2006-06-07 17:29 ` Stephen Hemminger [this message]
2006-06-08 6:35 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060607102950.54dd83c1@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).