From: David Miller <davem@davemloft.net>
To: auke-jan.h.kok@intel.com
Cc: jeremy@goop.org, mpm@selenic.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: Using netconsole for debugging suspend/resume
Date: Thu, 08 Jun 2006 22:23:52 -0700 (PDT) [thread overview]
Message-ID: <20060608.222352.59657133.davem@davemloft.net> (raw)
In-Reply-To: <4489038C.3050901@intel.com>
From: Auke Kok <auke-jan.h.kok@intel.com>
Date: Thu, 08 Jun 2006 22:13:48 -0700
> netconsole should retry. There is no timeout programmed here since that might
> lose important information, and you rather want netconsole to survive an odd
> unplugged cable then to lose vital debugging information when the system is
> busy for instance. (losing link will cause the interface to be down and thus
> the queue to be stopped)
I completely disagree that netpoll should loop when the ethernet
cable is plugged out. This stops the entire system. What if this
is one of my main web servers and I have other links on the machine
for redundancy and load balancing? Just because some careless
sysop knocks one of the cables out, my system just freezes up and
stops?
What if I'm on a remote serial console, how long should I scratch
my head wondering why the whole machine is frozen up before I "figure
out" that the ethernet cable being out has made my system unusable
because netpoll is just looping on the thing forever?
That's an extremely poor quality of implementation if you ask me.
Netpoll is _BEST_ _EFFORT_, end of story. It by definition can only
offer that level of service because it does locking in circumstances
where such locking might be illegal or even impossible. So it has to
try, but if it can't get the resources it needs, it must stop trying
and abort the logging.
next prev parent reply other threads:[~2006-06-09 5:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 17:50 Using netconsole for debugging suspend/resume Jeremy Fitzhardinge
2006-06-08 20:35 ` Auke Kok
2006-06-08 20:40 ` Rafael J. Wysocki
2006-06-09 1:56 ` Jeremy Fitzhardinge
2006-06-09 10:34 ` Rafael J. Wysocki
2006-06-08 21:07 ` Matt Mackall
2006-06-09 1:54 ` Jeremy Fitzhardinge
2006-06-09 5:13 ` Auke Kok
2006-06-09 5:23 ` David Miller [this message]
2006-06-09 5:50 ` Andi Kleen
2006-06-09 17:14 ` Matt Mackall
2006-06-09 5:45 ` Jeremy Fitzhardinge
2006-06-09 2:15 ` [PATCH RFC] netpoll: don't spin forever sending to stopped queues Jeremy Fitzhardinge
2006-06-11 20:04 ` Matt Mackall
2006-06-12 20:57 ` Jeremy Fitzhardinge
2006-06-12 20:53 ` Matt Mackall
2006-06-12 21:20 ` Jeremy Fitzhardinge
2006-06-09 3:46 ` Using netconsole for debugging suspend/resume Andi Kleen
2006-06-09 15:24 ` Mark Lord
2006-06-12 11:21 ` Andi Kleen
2006-06-12 15:38 ` Mark Lord
2006-06-12 15:46 ` Andi Kleen
2006-06-12 21:25 ` Jeremy Fitzhardinge
2006-06-13 3:47 ` Andi Kleen
2006-06-13 4:49 ` David Miller
2006-06-13 4:54 ` Andi Kleen
2006-06-13 5:03 ` David Miller
2006-06-13 7:18 ` Christoph Hellwig
2006-06-13 7:31 ` David Miller
2006-06-09 8:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060608.222352.59657133.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=auke-jan.h.kok@intel.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).