netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Daniel Drake <dsd@gentoo.org>
Cc: Jiri Benc <jbenc@suse.cz>,
	linville@tuxdriver.com,
	kernel list <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [patch] workaround zd1201 interference problem
Date: Thu, 8 Jun 2006 09:13:08 +0200	[thread overview]
Message-ID: <20060608071308.GA4086@elf.ucw.cz> (raw)
In-Reply-To: <20060608070525.GE3688@elf.ucw.cz>

Hi!

> > >Well, I'll try _enable() alone, but it seems to me that _enable()
> > >command is needed to initialize radio properly. I do not think we can
> > >get much further without firmware sources...
> > 
> > If you can formulate a proper and technical description of the issue 
> > (and exactly what is needed to workaround it), I can contact ZyDAS for 
> > you. They have been very helpful with ZD1211.
> 
> Okay, the issue is:
> 
> if you plug zd1201 into USB, it starts jamming radio,
> immediately. Enable/disable, or iwlist wlan0 scan, or basically any
> operation unjams the radio. This patch works it around:

Of course, the patch should have been:

 diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c
 index 335eaf3..dcc7bc7 100644
 --- a/drivers/net/wireless/zd1201.c
 +++ b/drivers/net/wireless/zd1201.c
 @@ -1835,6 +1835,8 @@ static int zd1201_probe(struct usb_inter
  	    zd->dev->name);
  	
  	usb_set_intfdata(interface, zd);
 +	zd1201_enable(zd);	/* zd1201 likes to startup enabled, interfering */
 +	zd1201_disable(zd); 	/* with all the wifis in range */
  	return 0;
  
  err_net:
 
 
 ....question is "is that right solution, or is something different
 needed to solve that problem properly"?
 								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2006-06-08  7:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-07 14:00 [patch] workaround zd1201 interference problem Pavel Machek
2006-06-07 14:08 ` Jiri Benc
2006-06-07 14:15   ` Pavel Machek
2006-06-07 16:22     ` Daniel Drake
2006-06-08  7:05       ` Pavel Machek
2006-06-08  7:13         ` Pavel Machek [this message]
2006-06-09 21:49         ` Daniel Drake
2006-06-09 22:38           ` Pavel Machek
2006-06-15 20:10             ` John W. Linville
2006-06-15 20:47               ` Pavel Machek
2006-07-12  0:13                 ` Daniel Drake
2006-06-15 21:00           ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2006-07-10 18:31 John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060608071308.GA4086@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=dsd@gentoo.org \
    --cc=jbenc@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).