From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [4/3] [NET]: Warn in __skb_trim if skb is paged
Date: Fri, 09 Jun 2006 16:13:51 -0700 (PDT) [thread overview]
Message-ID: <20060609.161351.107684565.davem@davemloft.net> (raw)
In-Reply-To: <20060609075538.GA22828@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 9 Jun 2006 17:55:39 +1000
> [NET]: Warn in __skb_trim if skb is paged
>
> It's better to warn and fail rather than rarely triggering BUG on paths
> that incorrectly call skb_trim/__skb_trim on a non-linear skb.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Agreed, patch applied, thanks a lot Herbert.
next prev parent reply other threads:[~2006-06-09 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-09 7:42 [1/3] [NET]: Clean up skb_linearize Herbert Xu
2006-06-09 7:43 ` [2/3] [NET] ppp: Remove unnecessary pskb_may_pull Herbert Xu
2006-06-09 23:12 ` David Miller
2006-06-09 7:44 ` [3/3] [NET]: skb_trim audit Herbert Xu
2006-06-09 23:13 ` David Miller
2006-06-09 7:55 ` [4/3] [NET]: Warn in __skb_trim if skb is paged Herbert Xu
2006-06-09 23:13 ` David Miller [this message]
2006-06-09 23:11 ` [1/3] [NET]: Clean up skb_linearize David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060609.161351.107684565.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).