From: Matt Mackall <mpm@selenic.com>
To: Andi Kleen <ak@suse.de>
Cc: David Miller <davem@davemloft.net>,
auke-jan.h.kok@intel.com, jeremy@goop.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Using netconsole for debugging suspend/resume
Date: Fri, 9 Jun 2006 12:14:07 -0500 [thread overview]
Message-ID: <20060609171407.GJ24227@waste.org> (raw)
In-Reply-To: <200606090750.25067.ak@suse.de>
On Fri, Jun 09, 2006 at 07:50:25AM +0200, Andi Kleen wrote:
> On Friday 09 June 2006 07:23, David Miller wrote:
> > From: Auke Kok <auke-jan.h.kok@intel.com>
> > Date: Thu, 08 Jun 2006 22:13:48 -0700
> >
> > > netconsole should retry. There is no timeout programmed here since that might
> > > lose important information, and you rather want netconsole to survive an odd
> > > unplugged cable then to lose vital debugging information when the system is
> > > busy for instance. (losing link will cause the interface to be down and thus
> > > the queue to be stopped)
> >
> > I completely disagree that netpoll should loop when the ethernet
> > cable is plugged out.
>
> Currently it is a bit dumb and doesn't distingush the various cases
> well.
>
> I submitted a patch to loop to be a bit more clever at some point. It can be still
> found in the netdev archives.
Agreed that timeouts should happen.
IIRC, the trouble with your patch was that it a) timed out on far too
short a timescale and b) locked up on my box. Unfortunately, so did my
own patch, which made timeouts approximately 1ms.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2006-06-09 17:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 17:50 Using netconsole for debugging suspend/resume Jeremy Fitzhardinge
2006-06-08 20:35 ` Auke Kok
2006-06-08 20:40 ` Rafael J. Wysocki
2006-06-09 1:56 ` Jeremy Fitzhardinge
2006-06-09 10:34 ` Rafael J. Wysocki
2006-06-08 21:07 ` Matt Mackall
2006-06-09 1:54 ` Jeremy Fitzhardinge
2006-06-09 5:13 ` Auke Kok
2006-06-09 5:23 ` David Miller
2006-06-09 5:50 ` Andi Kleen
2006-06-09 17:14 ` Matt Mackall [this message]
2006-06-09 5:45 ` Jeremy Fitzhardinge
2006-06-09 2:15 ` [PATCH RFC] netpoll: don't spin forever sending to stopped queues Jeremy Fitzhardinge
2006-06-11 20:04 ` Matt Mackall
2006-06-12 20:57 ` Jeremy Fitzhardinge
2006-06-12 20:53 ` Matt Mackall
2006-06-12 21:20 ` Jeremy Fitzhardinge
2006-06-09 3:46 ` Using netconsole for debugging suspend/resume Andi Kleen
2006-06-09 15:24 ` Mark Lord
2006-06-12 11:21 ` Andi Kleen
2006-06-12 15:38 ` Mark Lord
2006-06-12 15:46 ` Andi Kleen
2006-06-12 21:25 ` Jeremy Fitzhardinge
2006-06-13 3:47 ` Andi Kleen
2006-06-13 4:49 ` David Miller
2006-06-13 4:54 ` Andi Kleen
2006-06-13 5:03 ` David Miller
2006-06-13 7:18 ` Christoph Hellwig
2006-06-13 7:31 ` David Miller
2006-06-09 8:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060609171407.GJ24227@waste.org \
--to=mpm@selenic.com \
--cc=ak@suse.de \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).