[PATCH] net.ipv4.ip_autoconfig sysctl removal

[PATCH] net.ipv4.ip_autoconfig sysctl removal

[Stephen Hemminger]

The sysctl net.ipv4.ip_autoconfig is a legacy value that is not used.
Can it finally go in 2.6.18 or do we need to go through the whole 
feature-removal process?

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>


diff --git a/include/net/ip.h b/include/net/ip.h
index 3d2e5ca..ead233c 100644
--- a/include/net/ip.h
+++ b/include/net/ip.h
@@ -147,7 +147,6 @@ void ip_send_reply(struct sock *sk, stru
 struct ipv4_config
 {
 	int	log_martians;
-	int	autoconfig;
 	int	no_pmtu_disc;
 };
 
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index 6b6c3ad..9d2b81e 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -182,14 +182,6 @@ ctl_table ipv4_table[] = {
 		.strategy	= &ipv4_doint_and_flush_strategy,
 	},
         {
-		.ctl_name	= NET_IPV4_AUTOCONFIG,
-		.procname	= "ip_autoconfig",
-		.data		= &ipv4_config.autoconfig,
-		.maxlen		= sizeof(int),
-		.mode		= 0644,
-		.proc_handler	= &proc_dointvec
-	},
-        {
 		.ctl_name	= NET_IPV4_NO_PMTU_DISC,
 		.procname	= "ip_no_pmtu_disc",
 		.data		= &ipv4_config.no_pmtu_disc,

Re: [PATCH] net.ipv4.ip_autoconfig sysctl removal

[David Miller]

From: Stephen Hemminger <shemminger@osdl.org>
Date: Mon, 5 Jun 2006 10:58:31 -0700

> The sysctl net.ipv4.ip_autoconfig is a legacy value that is not used.
> Can it finally go in 2.6.18 or do we need to go through the whole 
> feature-removal process?
> 
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

I think killing this on in 2.6.18 is ok, applied.

Thanks.