From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: gerrit@erg.abdn.ac.uk, netdev@vger.kernel.org,
kaber@coreworks.de, jmorris@namei.org
Subject: Re: [ PATCH 2.6.17-rc6 1/1] udp.c: counting InDatagrams which are never delivered
Date: Sun, 11 Jun 2006 23:49:05 -0700 (PDT) [thread overview]
Message-ID: <20060611.234905.35014718.davem@davemloft.net> (raw)
In-Reply-To: <E1FpfkX-0000EL-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 12 Jun 2006 16:18:09 +1000
> David Miller <davem@davemloft.net> wrote:
> >
> > Probably a better way to handle this is to correct the
> > INDATAGRAMS value by decrementing it when we notice that
> > the checksum is incorrect in a deferred manner.
>
> I think sunrpc should instead increment the appropriate counters directly
> as otherwise checksum errors won't be recorded correctly for sunrpc packets.
Yeah. Good point. But how much protocol internals do we want to
slide into the ->data_ready() callbacks of such layers? That's ugly
and something we should try to avoid.
next prev parent reply other threads:[~2006-06-12 6:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-06 18:25 [ PATCH 2.6.17-rc6 1/1] udp.c: counting InDatagrams which are never delivered Gerrit Renker
2006-06-12 4:29 ` David Miller
2006-06-12 6:02 ` Gerrit Renker
2006-06-12 6:13 ` David Miller
2006-06-12 7:22 ` Gerrit Renker
2006-06-12 6:18 ` Herbert Xu
2006-06-12 6:49 ` David Miller [this message]
2006-06-12 7:43 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060611.234905.35014718.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=kaber@coreworks.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).