* Remove useless check for null dev from uli526x_interrupt()
@ 2006-06-12 0:27 Dave Jones
0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2006-06-12 0:27 UTC (permalink / raw)
To: netdev
As we're already dereferencing dev a few lines above, if this
check could ever trigger, we'd have already oopsed.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/drivers/net/tulip/uli526x.c~ 2006-06-11 20:24:41.000000000 -0400
+++ linux-2.6/drivers/net/tulip/uli526x.c 2006-06-11 20:25:14.000000000 -0400
@@ -666,11 +666,6 @@ static irqreturn_t uli526x_interrupt(int
unsigned long ioaddr = dev->base_addr;
unsigned long flags;
- if (!dev) {
- ULI526X_DBUG(1, "uli526x_interrupt() without DEVICE arg", 0);
- return IRQ_NONE;
- }
-
spin_lock_irqsave(&db->lock, flags);
outl(0, ioaddr + DCR7);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-12 0:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-12 0:27 Remove useless check for null dev from uli526x_interrupt() Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).