From: Michael Buesch <mb@bu3sch.de>
To: Jiri Benc <jbenc@suse.cz>
Cc: "John W. Linville" <linville@tuxdriver.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] bcm43xx-d80211: fix sending of fragments
Date: Mon, 12 Jun 2006 21:35:16 +0200 [thread overview]
Message-ID: <200606122135.17198.mb@bu3sch.de> (raw)
In-Reply-To: <20060612191606.7AA8E48391@silver.suse.cz>
On Monday 12 June 2006 21:16, Jiri Benc wrote:
> This makes fragmentation work with bcm43xx.
>
> Signed-off-by: Jiri Benc <jbenc@suse.cz>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
The other patch will get my sign-off tomorrow (I think modified, though).
I don't have time to look at it more close, now.
> ---
> drivers/net/wireless/d80211/bcm43xx/bcm43xx_dma.c | 2 +-
> drivers/net/wireless/d80211/bcm43xx/bcm43xx_pio.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- dscape.orig/drivers/net/wireless/d80211/bcm43xx/bcm43xx_dma.c
> +++ dscape/drivers/net/wireless/d80211/bcm43xx/bcm43xx_dma.c
> @@ -703,7 +703,7 @@ static int dma_tx_fragment(struct bcm43x
> bcm43xx_generate_txhdr(ring->bcm,
> (struct bcm43xx_txhdr *)hdr_skb->data,
> skb->data, skb->len,
> - 1,//FIXME
> + ctl->first_fragment,
> generate_cookie(ring, slot),
> ctl);
>
> --- dscape.orig/drivers/net/wireless/d80211/bcm43xx/bcm43xx_pio.c
> +++ dscape/drivers/net/wireless/d80211/bcm43xx/bcm43xx_pio.c
> @@ -183,7 +183,7 @@ static void pio_tx_write_fragment(struct
> assert(skb_shinfo(skb)->nr_frags == 0);
> bcm43xx_generate_txhdr(queue->bcm,
> &txhdr, skb->data, skb->len,
> - 1,//FIXME
> + packet->ctl->first_fragment,
> generate_cookie(queue, pio_txpacket_getindex(packet)),
> packet->ctl);
>
>
--
Greetings Michael.
next prev parent reply other threads:[~2006-06-12 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-12 19:16 [PATCH 0/5] d80211: better fragmentation handling Jiri Benc
2006-06-12 19:16 ` [PATCH 1/5] d80211: per-queue TX flow control Jiri Benc
2006-06-12 19:16 ` [incomplete 2/5] bcm43xx-d80211: " Jiri Benc
2006-06-12 19:16 ` [PATCH 3/5] d80211: handle full queue when sending fragments Jiri Benc
2006-06-12 19:16 ` [PATCH 4/5] d80211: add first_fragment flag to ieee80211_tx_control Jiri Benc
2006-06-12 19:16 ` [PATCH 5/5] bcm43xx-d80211: fix sending of fragments Jiri Benc
2006-06-12 19:35 ` Michael Buesch [this message]
2006-06-15 16:55 ` Michael Buesch
2006-06-15 20:27 ` Jiri Benc
2006-06-15 20:35 ` Michael Buesch
2006-06-14 16:36 ` [PATCH 6/5] rt2x00: per-queue TX flow control Jiri Benc
2006-06-14 18:35 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606122135.17198.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).