Netdev List
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: netdev@vger.kernel.org
Subject: [PATCH] DM9000 - do no re-init spin lock
Date: Wed, 14 Jun 2006 00:05:50 +0100	[thread overview]
Message-ID: <20060613230550.GA27024@home.fluff.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

The DM9000 initialisation sequence for the
hardware re-initialise the board spin-lock,
which is in my view wrong.

This patch removes the extra spin lock
initialisation

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

[-- Attachment #2: dm9k-no-spinlock-reinit.patch --]
[-- Type: text/plain, Size: 346 bytes --]

--- ../linux-2.6.17/linux-2.6.17-rc5/drivers/net/dm9000.c	2006-03-20 05:53:29.000000000 +0000
+++ linux-2.6.16-simtec2/drivers/net/dm9000.c	2006-05-22 21:46:18.000000000 +0100
@@ -663,7 +665,6 @@ dm9000_init_dm9000(struct net_device *de
 	db->tx_pkt_cnt = 0;
 	db->queue_pkt_len = 0;
 	dev->trans_start = 0;
-	spin_lock_init(&db->lock);
 }
 
 /*

                 reply	other threads:[~2006-06-13 23:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060613230550.GA27024@home.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox