From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Grundler Subject: Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late Date: Wed, 14 Jun 2006 16:30:21 -0600 Message-ID: <20060614223021.GB13212@colo.lackof.org> References: <20060531195234.GA4967@colo.lackof.org> <44883778.8000209@pobox.com> <20060608170120.GI8246@colo.lackof.org> <20060613235531.GA4191@colo.lackof.org> <448F5952.1060201@pobox.com> <20060614044412.GA30552@colo.lackof.org> <44902554.7010703@pobox.com> <20060614181419.GA10365@colo.lackof.org> <20060614204720.GA17887@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Grant Grundler , Jeff Garzik , Valerie Henson , Andrew Morton , netdev@vger.kernel.org Return-path: Received: from colo.lackof.org ([198.49.126.79]:59283 "EHLO colo.lackof.org") by vger.kernel.org with ESMTP id S964783AbWFNWaX (ORCPT ); Wed, 14 Jun 2006 18:30:23 -0400 To: Francois Romieu Content-Disposition: inline In-Reply-To: <20060614204720.GA17887@electric-eye.fr.zoreil.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Jun 14, 2006 at 10:47:20PM +0200, Francois Romieu wrote: > Grant Grundler : > [...] > > I'm not keen on adding more code to tulip_interrupt() routine > > for something that rarely happens (compared to IRQs) and is handled > > outside the interrupt routine. I'm pretty sure stopping interrupts > > before stopping DMA is sufficient. > > Can you show an example where it doesn't work? > > Shared irq. > > The device has not quiesced, the kernel stop listening to it and the > neighbor device receives a late interruption from the network device. I thought we've worked through that already: http://www.spinics.net/lists/netdev/msg05902.html Patch v3 takes care of that problem. The first step in the sequence is to mask IRQs on the tulip. The "neighbor" device sharing the IRQ will not see any interrupts from the tulip after that. thanks, grant