From: Ralf Baechle <ralf@linux-mips.org>
To: Ingo Oeser <netdev@axxeo.de>
Cc: netdev@vger.kernel.org, Jeff Garzik <jeff@garzik.org>
Subject: Re: [IOC3] IP27: Really set PCI64_ATTR_VIRTUAL, not PCI64_ATTR_PREC.
Date: Tue, 20 Jun 2006 11:02:36 +0100 [thread overview]
Message-ID: <20060620100236.GA4288@linux-mips.org> (raw)
In-Reply-To: <200606201015.01323.netdev@axxeo.de>
On Tue, Jun 20, 2006 at 10:15:01AM +0200, Ingo Oeser wrote:
> From: Ingo Oeser <netdev@axxeo.de>
> To: Ralf Baechle <ralf@linux-mips.org>
> Subject: Re: [IOC3] IP27: Really set PCI64_ATTR_VIRTUAL, not PCI64_ATTR_PREC.
> Date: Tue, 20 Jun 2006 10:15:01 +0200
> Cc: netdev@vger.kernel.org, Jeff Garzik <jeff@garzik.org>
> Content-Type: text/plain;
> charset="iso-8859-1"
>
> Hi Ralf,
>
> Ralf Baechle :
> > IOC3's homegrown DMA mapping functions that are used to optimize things
> > a little on IP27 set the wrong bit.
>
> What about using a symbol instead of magic numbers?
> That way one at least sees the intention of the coder.
>
> > Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> >
> > diff --git a/drivers/net/ioc3-eth.c b/drivers/net/ioc3-eth.c
> > index ae71ed5..e76e6e7 100644
> > --- a/drivers/net/ioc3-eth.c
> > +++ b/drivers/net/ioc3-eth.c
> > @@ -145,7 +145,7 @@ static inline struct sk_buff * ioc3_allo
> > static inline unsigned long ioc3_map(void *ptr, unsigned long vdev)
> > {
> > #ifdef CONFIG_SGI_IP27
> > - vdev <<= 58; /* Shift to PCI64_ATTR_VIRTUAL */
> > + vdev <<= 57; /* Shift to PCI64_ATTR_VIRTUAL */
>
> So please use a symbolic value here.
It is a hack and meant to look like one, loudly marked with #ifdef.
Ralf
prev parent reply other threads:[~2006-06-20 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-17 17:57 [IOC3] IP27: Really set PCI64_ATTR_VIRTUAL, not PCI64_ATTR_PREC Ralf Baechle
2006-06-20 8:15 ` Ingo Oeser
2006-06-20 10:02 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060620100236.GA4288@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jeff@garzik.org \
--cc=netdev@axxeo.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).