* [-mm patch] drivers/net/ni5010.c: fix compile error
[not found] <20060621034857.35cfe36f.akpm@osdl.org>
@ 2006-06-21 15:10 ` Adrian Bunk
2006-06-22 8:13 ` Andreas Mohr
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-06-21 15:10 UTC (permalink / raw)
To: Andrew Morton, Andreas Mohr; +Cc: linux-kernel, jgarzik, netdev
On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-rc6-mm2:
>...
> +ni5010-netcard-cleanup.patch
>
> netdev cleanup
>...
This patch fixes the following compile error with CONFIG_NI5010=y:
<-- snip -->
...
LD .tmp_vmlinux1
drivers/built-in.o:(.init.data+0x2b280): undefined reference to `ni5010_probe'
make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.17-mm1-full/drivers/net/ni5010.c.old 2006-06-21 16:21:26.000000000 +0200
+++ linux-2.6.17-mm1-full/drivers/net/ni5010.c 2006-06-21 16:21:46.000000000 +0200
@@ -117,7 +117,7 @@
static int io;
static int irq;
-static struct net_device * __init ni5010_probe(int unit)
+struct net_device * __init ni5010_probe(int unit)
{
struct net_device *dev = alloc_etherdev(sizeof(struct ni5010_local));
int *port;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [-mm patch] drivers/net/ni5010.c: fix compile error
2006-06-21 15:10 ` [-mm patch] drivers/net/ni5010.c: fix compile error Adrian Bunk
@ 2006-06-22 8:13 ` Andreas Mohr
2006-06-22 8:45 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Mohr @ 2006-06-22 8:13 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel, jgarzik, netdev
Hi,
On Wed, Jun 21, 2006 at 05:10:57PM +0200, Adrian Bunk wrote:
> On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.17-rc6-mm2:
> >...
> > +ni5010-netcard-cleanup.patch
> >
> > netdev cleanup
> >...
>
> This patch fixes the following compile error with CONFIG_NI5010=y:
Doh, thanks!
(that should teach me to do non-module runs, too)
Andreas Mohr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [-mm patch] drivers/net/ni5010.c: fix compile error
2006-06-22 8:13 ` Andreas Mohr
@ 2006-06-22 8:45 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-06-22 8:45 UTC (permalink / raw)
To: Andreas Mohr; +Cc: Andrew Morton, linux-kernel, jgarzik, netdev
On Thu, Jun 22, 2006 at 10:13:16AM +0200, Andreas Mohr wrote:
> Hi,
>
> On Wed, Jun 21, 2006 at 05:10:57PM +0200, Adrian Bunk wrote:
> > On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.17-rc6-mm2:
> > >...
> > > +ni5010-netcard-cleanup.patch
> > >
> > > netdev cleanup
> > >...
> >
> > This patch fixes the following compile error with CONFIG_NI5010=y:
>
> Doh, thanks!
> (that should teach me to do non-module runs, too)
And change the driver to no longer use Space.c? ;-)
> Andreas Mohr
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-06-22 8:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060621034857.35cfe36f.akpm@osdl.org>
2006-06-21 15:10 ` [-mm patch] drivers/net/ni5010.c: fix compile error Adrian Bunk
2006-06-22 8:13 ` Andreas Mohr
2006-06-22 8:45 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).