From: David Miller <davem@davemloft.net>
To: swise@opengridcomputing.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH REPOST 1/2] Network Event Notifier Mechanism.
Date: Fri, 23 Jun 2006 13:26:47 -0700 (PDT) [thread overview]
Message-ID: <20060623.132647.39159829.davem@davemloft.net> (raw)
In-Reply-To: <20060623201928.32482.69191.stgit@stevo-desktop>
From: Steve Wise <swise@opengridcomputing.com>
Date: Fri, 23 Jun 2006 15:19:28 -0500
> +struct netevent_route_change {
> + int event;
> + struct fib_info *fib_info;
> +};
It's not generic if you're putting ipv4 FIB route objects
in the datastructure.
This is so much unnecessary syntactic sugar for what you're
trying to accomplish.
Just pass a "void *", and have the type of the object defined by which
notifier it is. This is exactly how all notifiers work today.
Then you don't need any new infrastructure at all. The existing
notifier bits handle this kind of scheme already, no need to
invent new stuff.
next prev parent reply other threads:[~2006-06-23 20:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 20:19 [PATCH REPOST 0/2][RFC] Network Event Notifier Mechanism Steve Wise
2006-06-23 20:19 ` [PATCH REPOST 1/2] " Steve Wise
2006-06-23 20:26 ` David Miller [this message]
2006-06-23 20:34 ` Steve Wise
2006-06-23 20:56 ` David Miller
2006-06-24 2:27 ` Steve Wise
2006-06-26 15:26 ` Steve Wise
2006-06-26 17:43 ` David Miller
2006-06-26 18:28 ` Steve Wise
2006-06-23 20:19 ` [PATCH REPOST 2/2] Core network changes to support network event notification Steve Wise
2006-06-27 12:50 ` [PATCH REPOST 0/2][RFC] Network Event Notifier Mechanism Herbert Xu
2006-06-27 14:31 ` Steve Wise
2006-06-27 22:32 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623.132647.39159829.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).