Netdev List
 help / color / mirror / Atom feed
From: Lennert Buytenhek <buytenh@wantstofly.org>
To: jgarzik@pobox.com, netdev@vger.kernel.org
Cc: nico@cam.org, mikee@logicpd.com, peterb@logicpd.com
Subject: [PATCH] smc91x: disable DMA mode on the logicpd pxa270
Date: Fri, 23 Jun 2006 23:24:36 +0200	[thread overview]
Message-ID: <20060623212436.GB4843@xi.wantstofly.org> (raw)

Enabling PXA DMA for the smc91x on the logicpd pxa270 produces
unacceptable interference with the TFT panel, so disable it.  Also
delete the lpd270 versions of the SMC_{in,out}[bl]() macros, as they
aren't used, since the board only supports 16bit accesses.

Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>

Index: linux-2.6.17-git5/drivers/net/smc91x.h
===================================================================
--- linux-2.6.17-git5.orig/drivers/net/smc91x.h
+++ linux-2.6.17-git5/drivers/net/smc91x.h
@@ -136,14 +136,9 @@
 #define SMC_CAN_USE_32BIT	0
 #define SMC_IO_SHIFT		0
 #define SMC_NOWAIT		1
-#define SMC_USE_PXA_DMA		1
 
-#define SMC_inb(a, r)		readb((a) + (r))
 #define SMC_inw(a, r)		readw((a) + (r))
-#define SMC_inl(a, r)		readl((a) + (r))
-#define SMC_outb(v, a, r)	writeb(v, (a) + (r))
 #define SMC_outw(v, a, r)	writew(v, (a) + (r))
-#define SMC_outl(v, a, r)	writel(v, (a) + (r))
 #define SMC_insw(a, r, p, l)	readsw((a) + (r), p, l)
 #define SMC_outsw(a, r, p, l)	writesw((a) + (r), p, l)

             reply	other threads:[~2006-06-23 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-23 21:24 Lennert Buytenhek [this message]
2006-06-27  2:02 ` [PATCH] smc91x: disable DMA mode on the logicpd pxa270 Jeff Garzik
2006-06-27  2:08   ` Lennert Buytenhek
2006-06-27  2:14     ` Lennert Buytenhek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060623212436.GB4843@xi.wantstofly.org \
    --to=buytenh@wantstofly.org \
    --cc=jgarzik@pobox.com \
    --cc=mikee@logicpd.com \
    --cc=netdev@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=peterb@logicpd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox