From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: mchan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH]NET: Fix GSO problems in dev_hard_start_xmit()
Date: Sun, 25 Jun 2006 23:57:24 -0700 (PDT) [thread overview]
Message-ID: <20060625.235724.130237223.davem@davemloft.net> (raw)
In-Reply-To: <20060625233602.GA22255@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 26 Jun 2006 09:36:02 +1000
> On Sun, Jun 25, 2006 at 03:38:05PM -0700, Michael Chan wrote:
> > Fix 2 problems in dev_hard_start_xmit():
> >
> > 1. nskb->next needs to link back to skb->next if hard_start_xmit()
> > returns non-zero.
> >
> > 2. Since the total number of GSO fragments may exceed MAX_SKB_FRAGS + 1,
> > it needs to stop transmitting if the netif_queue is stopped.
> >
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> Good catch.
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks.
prev parent reply other threads:[~2006-06-26 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 22:38 [PATCH]NET: Fix GSO problems in dev_hard_start_xmit() Michael Chan
2006-06-25 23:36 ` Herbert Xu
2006-06-26 6:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060625.235724.130237223.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).