Re: [PATCH Round 2 0/2][RFC] Network Event Notifier Mechanism

[David Miller <davem@davemloft.net>]

From: Steve Wise <swise@opengridcomputing.com>
Date: Mon, 26 Jun 2006 15:36:38 -0500

> Round 2 Changes:
> 
> - cleaned up event structures per review feedback.
> - began integration with netlink (see neighbour changes in patch 2).
> - added IPv6 support.

Yes, ipv6 support is the main think I saw lacking.
Especially the neighbour stuff.

How will you interpret the neighbour object properly, by
looking at neigh->ops->family?

> Questions:
> 
> - this patch is enabling some of the functionality that was under
>   CONFIG_ARPD.  Should I remove the CONFIG_ARPD stuff, leave it as-is
>   or what?

I think how you changed it is fine.

> - what about support for other afs?  Should I hook AF_DECnet?  IPX? Or is
>   AF_INET and AF_INET6 sufficient?

Probably this should be done on an as-needed basis.

> - I added a new RTM type in rtnetlink.h for neighbour change netlink
>   messages.  I suspect I did it wrong...

The low 3-bits of rtnetlink commands indicate the "kind".
So you have to be careful.  See rtnetlink_rcv_msg() for details.

You also have to update the tables in net/core/rtnetlink.c when
you add new values.  In particular rt_min[].