From: David Miller <davem@davemloft.net>
To: sri@us.ibm.com
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH] Export accept queue len of a TCP listening socket via rx_queue
Date: Tue, 27 Jun 2006 13:29:15 -0700 (PDT) [thread overview]
Message-ID: <20060627.132915.85418118.davem@davemloft.net> (raw)
In-Reply-To: <1150997897.8365.11.camel@w-sridhar2.beaverton.ibm.com>
From: Sridhar Samudrala <sri@us.ibm.com>
Date: Thu, 22 Jun 2006 10:38:17 -0700
> On Thu, 2006-06-22 at 10:50 +1000, Herbert Xu wrote:
> > Sridhar Samudrala <sri@us.ibm.com> wrote:
> > >>
> > >> What about using the same fields (rqueue/wqueue) as you did for /proc?
> > >
> > > I meant extending tcp_info structure to add new fields. I think the user
> > > space also uses this structure.
> >
> > What about putting it into inet_idiag_msg.idiag_[rw]queue instead?
>
> OK. I was under the mistaken assumption that [rw]queue fields are exported
> via tcp_info. This makes it pretty simple to support netlink users also.
> Here is the updated patch.
This looks fine. Applied, thanks a lot Sridhar.
prev parent reply other threads:[~2006-06-27 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 23:56 [PATCH] Export accept queue len of a TCP listening socket via /proc/net/tcp{6} Sridhar Samudrala
2006-06-22 0:21 ` Herbert Xu
2006-06-22 0:35 ` Sridhar Samudrala
2006-06-22 0:50 ` Herbert Xu
2006-06-22 17:38 ` [PATCH] Export accept queue len of a TCP listening socket via rx_queue Sridhar Samudrala
2006-06-27 20:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060627.132915.85418118.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox