From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lennert Buytenhek Subject: Re: [PATCH] smc91x: disable DMA mode on the logicpd pxa270 Date: Tue, 27 Jun 2006 04:08:31 +0200 Message-ID: <20060627020831.GA20393@xi.wantstofly.org> References: <20060623212436.GB4843@xi.wantstofly.org> <44A091CC.90607@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, nico@cam.org, mikee@logicpd.com, peterb@logicpd.com Return-path: Received: from alephnull.demon.nl ([83.160.184.112]:1472 "EHLO xi.wantstofly.org") by vger.kernel.org with ESMTP id S1030603AbWF0CIg (ORCPT ); Mon, 26 Jun 2006 22:08:36 -0400 To: Jeff Garzik Content-Disposition: inline In-Reply-To: <44A091CC.90607@pobox.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Jun 26, 2006 at 10:02:52PM -0400, Jeff Garzik wrote: > >Enabling PXA DMA for the smc91x on the logicpd pxa270 produces > >unacceptable interference with the TFT panel, so disable it. Also > >delete the lpd270 versions of the SMC_{in,out}[bl]() macros, as they > >aren't used, since the board only supports 16bit accesses. > > > >Signed-off-by: Lennert Buytenhek > > > >Index: linux-2.6.17-git5/drivers/net/smc91x.h > > ACK, but git-applymbox claims the patch is corrupt Hmmm, non-quilt style patch better? == Enabling PXA DMA for the smc91x on the logicpd pxa270 produces unacceptable interference with the TFT panel, so disable it. Also delete the lpd270 versions of the SMC_{in,out}[bl]() macros, as they aren't used, since the board only supports 16bit accesses. Signed-off-by: Lennert Buytenhek --- linux-2.6.17-git10.orig/drivers/net/smc91x.h 2006-06-27 04:05:20.000000000 +0200 +++ linux-2.6.17-git10/drivers/net/smc91x.h 2006-06-27 04:05:47.000000000 +0200 @@ -136,14 +136,9 @@ #define SMC_CAN_USE_32BIT 0 #define SMC_IO_SHIFT 0 #define SMC_NOWAIT 1 -#define SMC_USE_PXA_DMA 1 -#define SMC_inb(a, r) readb((a) + (r)) #define SMC_inw(a, r) readw((a) + (r)) -#define SMC_inl(a, r) readl((a) + (r)) -#define SMC_outb(v, a, r) writeb(v, (a) + (r)) #define SMC_outw(v, a, r) writew(v, (a) + (r)) -#define SMC_outl(v, a, r) writel(v, (a) + (r)) #define SMC_insw(a, r, p, l) readsw((a) + (r), p, l) #define SMC_outsw(a, r, p, l) writesw((a) + (r), p, l)