netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Ron Mercer" <ron.mercer@qlogic.com>
Cc: netdev@vger.kernel.org, Linux-Driver@qlogic.com
Subject: Re: FW: + qla3xxx-is-bust.patch added to -mm tree
Date: Wed, 28 Jun 2006 16:24:00 -0700	[thread overview]
Message-ID: <20060628162400.4e7b73ac.akpm@osdl.org> (raw)
In-Reply-To: <0BB3E5E7462EEA4295BC02D49691DC07176D31@AVEXCH1.qlogic.org>

"Ron Mercer" <ron.mercer@qlogic.com> wrote:
>
> > 
> > Is the device hotpluggable?   If so, this:
> > 
> > 	qdev->index = cards_found;
> > 
> > in the probe() handler might do odd things - it'll just keep 
> > increasing as the card is removed and re-added.
> > 
> > iirc, that's a common problem with net drivers.  AFAICT it'll 
> > cause only cosmetic oddities here.
> > 
> >
> 
> Not sure if the device supports hotplug.  I'm looking into it.  Either
> way, I will be removing qdev->index.  It's not needed. 
> 
> I am working on the remaining items that Jeff pointed out when he
> reviewed my driver.  I will forward a patch built against what you
> currently have when I'm done.

OK.

> Now that the driver is in mm tree, is there anything I need to do to get
> it into Linus' tree?

It should go via Jeff.  I added it to -mm just to get it a bit of
attention, more reviewers, extra compile coverage testing, etc.

If you want to consider the patch in -mm to be the reference copy then
that's fine.  You should do maintenance work against that patch and I'll
add it to the patches which I send to Jeff on Thursdays until he merges it
or rejects it.

  reply	other threads:[~2006-06-28 23:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 23:07 FW: + qla3xxx-is-bust.patch added to -mm tree Ron Mercer
2006-06-28 23:24 ` Andrew Morton [this message]
2006-06-29  1:37 ` Jeff Garzik
2006-06-29  3:41 ` Doug Maxey
  -- strict thread matches above, loose matches on Subject: below --
2006-07-13 18:13 Ron Mercer
2006-07-13 16:57 Ron Mercer
2006-07-13 17:06 ` Jeff Garzik
2006-06-26 19:02 Ron Mercer
2006-06-26 19:24 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060628162400.4e7b73ac.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=Linux-Driver@qlogic.com \
    --cc=netdev@vger.kernel.org \
    --cc=ron.mercer@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).