From: Adrian Bunk <bunk@stusta.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] make net/core/skbuff.c:skb_release_data() static
Date: Thu, 29 Jun 2006 21:20:20 +0200 [thread overview]
Message-ID: <20060629192020.GR19712@stusta.de> (raw)
In-Reply-To: <20060623.040115.108744369.davem@davemloft.net>
On Fri, Jun 23, 2006 at 04:01:15AM -0700, David Miller wrote:
> From: Adrian Bunk <bunk@stusta.de>
> Date: Fri, 23 Jun 2006 12:56:23 +0200
>
> > skb_release_data() no longer has any users in other files.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> If you are going to do this, you need to remove the reference
> in arch/x86_64/kernel/functionlist too.
>
> Thanks.
Corrected patch below.
cu
Adrian
<-- snip -->
skb_release_data() no longer has any users in other files.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/x86_64/kernel/functionlist | 1 -
include/linux/skbuff.h | 1 -
net/core/skbuff.c | 2 +-
3 files changed, 1 insertion(+), 3 deletions(-)
--- linux-2.6.17-mm4-full/include/linux/skbuff.h.old 2006-06-29 15:19:52.000000000 +0200
+++ linux-2.6.17-mm4-full/include/linux/skbuff.h 2006-06-29 15:19:59.000000000 +0200
@@ -1301,7 +1301,6 @@
extern void skb_split(struct sk_buff *skb,
struct sk_buff *skb1, const u32 len);
-extern void skb_release_data(struct sk_buff *skb);
extern struct sk_buff *skb_segment(struct sk_buff *skb, int sg);
static inline void *skb_header_pointer(const struct sk_buff *skb, int offset,
--- linux-2.6.17-mm4-full/net/core/skbuff.c.old 2006-06-29 15:20:10.000000000 +0200
+++ linux-2.6.17-mm4-full/net/core/skbuff.c 2006-06-29 15:20:17.000000000 +0200
@@ -279,7 +279,7 @@
skb_get(list);
}
-void skb_release_data(struct sk_buff *skb)
+static void skb_release_data(struct sk_buff *skb)
{
if (!skb->cloned ||
!atomic_sub_return(skb->nohdr ? (1 << SKB_DATAREF_SHIFT) + 1 : 1,
--- linux-2.6.17-mm4-full/arch/x86_64/kernel/functionlist.old 2006-06-29 15:20:26.000000000 +0200
+++ linux-2.6.17-mm4-full/arch/x86_64/kernel/functionlist 2006-06-29 15:20:30.000000000 +0200
@@ -384,7 +384,6 @@
*(.text.__end_that_request_first)
*(.text.wake_up_bit)
*(.text.unuse_mm)
-*(.text.skb_release_data)
*(.text.shrink_icache_memory)
*(.text.sched_balance_self)
*(.text.__pmd_alloc)
next prev parent reply other threads:[~2006-06-29 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 10:56 [2.6 patch] make net/core/skbuff.c:skb_release_data() static Adrian Bunk
2006-06-23 11:01 ` David Miller
2006-06-29 19:20 ` Adrian Bunk [this message]
2006-06-29 20:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060629192020.GR19712@stusta.de \
--to=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).