* [2.6 patch] make net/core/skbuff.c:skb_release_data() static
@ 2006-06-23 10:56 Adrian Bunk
2006-06-23 11:01 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2006-06-23 10:56 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel
skb_release_data() no longer has any users in other files.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
include/linux/skbuff.h | 2 --
net/core/skbuff.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
--- linux-2.6.17-mm1-full/include/linux/skbuff.h.old 2006-06-23 00:45:40.000000000 +0200
+++ linux-2.6.17-mm1-full/include/linux/skbuff.h 2006-06-23 00:46:37.000000000 +0200
@@ -1289,8 +1289,6 @@
extern void skb_split(struct sk_buff *skb,
struct sk_buff *skb1, const u32 len);
-extern void skb_release_data(struct sk_buff *skb);
-
static inline void *skb_header_pointer(const struct sk_buff *skb, int offset,
int len, void *buffer)
{
--- linux-2.6.17-mm1-full/net/core/skbuff.c.old 2006-06-23 00:46:44.000000000 +0200
+++ linux-2.6.17-mm1-full/net/core/skbuff.c 2006-06-23 00:46:50.000000000 +0200
@@ -292,7 +292,7 @@
skb_get(list);
}
-void skb_release_data(struct sk_buff *skb)
+static void skb_release_data(struct sk_buff *skb)
{
if (!skb->cloned ||
!atomic_sub_return(skb->nohdr ? (1 << SKB_DATAREF_SHIFT) + 1 : 1,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6 patch] make net/core/skbuff.c:skb_release_data() static
2006-06-23 10:56 [2.6 patch] make net/core/skbuff.c:skb_release_data() static Adrian Bunk
@ 2006-06-23 11:01 ` David Miller
2006-06-29 19:20 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2006-06-23 11:01 UTC (permalink / raw)
To: bunk; +Cc: netdev, linux-kernel
From: Adrian Bunk <bunk@stusta.de>
Date: Fri, 23 Jun 2006 12:56:23 +0200
> skb_release_data() no longer has any users in other files.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
If you are going to do this, you need to remove the reference
in arch/x86_64/kernel/functionlist too.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] make net/core/skbuff.c:skb_release_data() static
2006-06-23 11:01 ` David Miller
@ 2006-06-29 19:20 ` Adrian Bunk
2006-06-29 20:03 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2006-06-29 19:20 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel
On Fri, Jun 23, 2006 at 04:01:15AM -0700, David Miller wrote:
> From: Adrian Bunk <bunk@stusta.de>
> Date: Fri, 23 Jun 2006 12:56:23 +0200
>
> > skb_release_data() no longer has any users in other files.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> If you are going to do this, you need to remove the reference
> in arch/x86_64/kernel/functionlist too.
>
> Thanks.
Corrected patch below.
cu
Adrian
<-- snip -->
skb_release_data() no longer has any users in other files.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/x86_64/kernel/functionlist | 1 -
include/linux/skbuff.h | 1 -
net/core/skbuff.c | 2 +-
3 files changed, 1 insertion(+), 3 deletions(-)
--- linux-2.6.17-mm4-full/include/linux/skbuff.h.old 2006-06-29 15:19:52.000000000 +0200
+++ linux-2.6.17-mm4-full/include/linux/skbuff.h 2006-06-29 15:19:59.000000000 +0200
@@ -1301,7 +1301,6 @@
extern void skb_split(struct sk_buff *skb,
struct sk_buff *skb1, const u32 len);
-extern void skb_release_data(struct sk_buff *skb);
extern struct sk_buff *skb_segment(struct sk_buff *skb, int sg);
static inline void *skb_header_pointer(const struct sk_buff *skb, int offset,
--- linux-2.6.17-mm4-full/net/core/skbuff.c.old 2006-06-29 15:20:10.000000000 +0200
+++ linux-2.6.17-mm4-full/net/core/skbuff.c 2006-06-29 15:20:17.000000000 +0200
@@ -279,7 +279,7 @@
skb_get(list);
}
-void skb_release_data(struct sk_buff *skb)
+static void skb_release_data(struct sk_buff *skb)
{
if (!skb->cloned ||
!atomic_sub_return(skb->nohdr ? (1 << SKB_DATAREF_SHIFT) + 1 : 1,
--- linux-2.6.17-mm4-full/arch/x86_64/kernel/functionlist.old 2006-06-29 15:20:26.000000000 +0200
+++ linux-2.6.17-mm4-full/arch/x86_64/kernel/functionlist 2006-06-29 15:20:30.000000000 +0200
@@ -384,7 +384,6 @@
*(.text.__end_that_request_first)
*(.text.wake_up_bit)
*(.text.unuse_mm)
-*(.text.skb_release_data)
*(.text.shrink_icache_memory)
*(.text.sched_balance_self)
*(.text.__pmd_alloc)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6 patch] make net/core/skbuff.c:skb_release_data() static
2006-06-29 19:20 ` Adrian Bunk
@ 2006-06-29 20:03 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2006-06-29 20:03 UTC (permalink / raw)
To: bunk; +Cc: netdev, linux-kernel
From: Adrian Bunk <bunk@stusta.de>
Date: Thu, 29 Jun 2006 21:20:20 +0200
> On Fri, Jun 23, 2006 at 04:01:15AM -0700, David Miller wrote:
> > From: Adrian Bunk <bunk@stusta.de>
> > Date: Fri, 23 Jun 2006 12:56:23 +0200
> >
> > > skb_release_data() no longer has any users in other files.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > If you are going to do this, you need to remove the reference
> > in arch/x86_64/kernel/functionlist too.
> >
> > Thanks.
>
> Corrected patch below.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-29 20:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-23 10:56 [2.6 patch] make net/core/skbuff.c:skb_release_data() static Adrian Bunk
2006-06-23 11:01 ` David Miller
2006-06-29 19:20 ` Adrian Bunk
2006-06-29 20:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).