From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Jackson Subject: Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats Date: Thu, 29 Jun 2006 19:43:44 -0700 Message-ID: <20060629194344.6a29dba7.pj@sgi.com> References: <44892610.6040001@watson.ibm.com> <449CAA78.4080902@watson.ibm.com> <20060623213912.96056b02.akpm@osdl.org> <449CD4B3.8020300@watson.ibm.com> <44A01A50.1050403@sgi.com> <20060626105548.edef4c64.akpm@osdl.org> <44A020CD.30903@watson.ibm.com> <20060626111249.7aece36e.akpm@osdl.org> <44A026ED.8080903@sgi.com> <20060626113959.839d72bc.akpm@osdl.org> <44A2F50D.8030306@engr.sgi.com> <20060628145341.529a61ab.akpm@osdl.org> <44A2FC72.9090407@engr.sgi.com> <20060629014050.d3bf0be4.pj@sgi.com> <200606291230.k5TCUg45030710@turing-police.cc.vt.edu> <20060629094408.360ac157.pj@sgi.com> <20060629110107.2e56310b.akpm@osdl.org> <44A425A7.2060900@watson.ibm.com> <20060629123338.0d355297.akpm@osdl.org> <44A43187.3090307@watson.ibm.com> <1151621692.8922.4.camel@jzny2> <44A47285.6060307@watson.ibm.com> <20060629180502.3987a98e.akpm@osdl.org> <20060629192526.360aa579.pj@sgi.com> <20060629193500.d4676f13.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: nagar@watson.ibm.com, hadi@cyberus.ca, Valdis.Kletnieks@vt.edu, jlan@engr.sgi.com, balbir@in.ibm.com, csturtiv@sgi.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: Received: from omx1-ext.sgi.com ([192.48.179.11]:42191 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S1751431AbWF3CoN (ORCPT ); Thu, 29 Jun 2006 22:44:13 -0400 To: Andrew Morton In-Reply-To: <20060629193500.d4676f13.akpm@osdl.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Andrew wrote: > Nah. Stick it in the same cacheline as tasklist_lock (I'm amazed that > we've continued to get away with a global lock for that). Yes - a bit amazing. But no sense compounding the problem now. We shouldn't be adding global locks/modifiable data in the fork/exit code path if we can help it, without at least providing some simple way to ameliorate the problem when folks do start hitting it. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.925.600.0401