* [PATCH 1/2] [IrDA] Fix RCU lock pairing on error path [not found] ` <20060629142741.GA1294-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> @ 2006-06-30 6:55 ` Samuel Ortiz [not found] ` <20060630065534.GA4729-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Samuel Ortiz @ 2006-06-30 6:55 UTC (permalink / raw) To: Paul E. McKenney, David S. Miller, Josh Triplett Cc: Andrew Morton, netdev-u79uwXL29TY76Z2rM5mHXA, irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Dipkanar Sarma Hi Dave, irlan_client_discovery_indication calls rcu_read_lock and rcu_read_unlock, but returns without unlocking in an error case. Fix that by replacing the return with a goto so that the rcu_read_unlock always gets executed. Signed-off-by: Josh Triplett <josh-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org> Acked-by: Paul E. McKenney <paulmck-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> Signed-off-by: Samuel Ortiz samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org <> --- net/irda/irlan/irlan_client.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/irda/irlan/irlan_client.c b/net/irda/irlan/irlan_client.c index f8e6cb0..95cf123 100644 --- a/net/irda/irlan/irlan_client.c +++ b/net/irda/irlan/irlan_client.c @@ -173,13 +173,14 @@ void irlan_client_discovery_indication(d rcu_read_lock(); self = irlan_get_any(); if (self) { - IRDA_ASSERT(self->magic == IRLAN_MAGIC, return;); + IRDA_ASSERT(self->magic == IRLAN_MAGIC, goto out;); IRDA_DEBUG(1, "%s(), Found instance (%08x)!\n", __FUNCTION__ , daddr); irlan_client_wakeup(self, saddr, daddr); } +IRDA_ASSERT_LABEL(out:) rcu_read_unlock(); } -- 1.4.0 Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <20060630065534.GA4729-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH 1/2] [IrDA] Fix RCU lock pairing on error path [not found] ` <20060630065534.GA4729-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org> @ 2006-06-30 0:02 ` David Miller 0 siblings, 0 replies; 2+ messages in thread From: David Miller @ 2006-06-30 0:02 UTC (permalink / raw) To: samuel-jcdQHdrhKHMdnm+yROfE0A Cc: akpm-3NddpPZAyC0, josht-DhXWPJtHtuFWk0Htik3J/w, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, paulmck-r/Jw6+rmf7HQT0dZR+AlfA, irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, dipankar-xthvdsQ13ZrQT0dZR+AlfA From: Samuel Ortiz <samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org> Date: Fri, 30 Jun 2006 09:55:34 +0300 > irlan_client_discovery_indication calls rcu_read_lock and rcu_read_unlock, but > returns without unlocking in an error case. Fix that by replacing the return > with a goto so that the rcu_read_unlock always gets executed. > > Signed-off-by: Josh Triplett <josh-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org> > Acked-by: Paul E. McKenney <paulmck-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> > Signed-off-by: Samuel Ortiz samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org <> Applied, thanks. Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-30 6:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1151542602.18723.19.camel@josh-work.beaverton.ibm.com>
[not found] ` <20060629142741.GA1294@us.ibm.com>
[not found] ` <20060629142741.GA1294-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2006-06-30 6:55 ` [PATCH 1/2] [IrDA] Fix RCU lock pairing on error path Samuel Ortiz
[not found] ` <20060630065534.GA4729-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2006-06-30 0:02 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).