From: David Miller <davem@davemloft.net>
To: ralf@linux-mips.org
Cc: netdev@vger.kernel.org
Subject: Re: Off by one buglets
Date: Mon, 03 Jul 2006 19:34:15 -0700 (PDT) [thread overview]
Message-ID: <20060703.193415.48529803.davem@davemloft.net> (raw)
In-Reply-To: <20060630142901.GA13898@linux-mips.org>
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 30 Jun 2006 15:29:01 +0100
> Ages ago, changeset
>
> http://www.kernel.org/git/?p=linux/kernel/git/tglx/history.git;a=commit;h=22d864d542a0b92116751186f1794c7d0f1ca1b9
>
> which converted several protocols from using open coded comparisons to
> use the helper function sk_acceptq_is_full() did introduce a bunch of
> off by one errors - sk_acceptq_is_full checks for
> sk_ack_backlog > sk_max_ack_backlog but it replaced >= or == comparisons.
>
> Below patch is really only meant to illustrate the change, not to be
> applied.
Ok, I'll try to resolve this when I get back from my vacation
unless someone beats me to it.
Thanks for the heads up Ralf.
next prev parent reply other threads:[~2006-07-04 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-30 14:29 Off by one buglets Ralf Baechle
2006-07-04 2:34 ` David Miller [this message]
2006-07-31 22:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060703.193415.48529803.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).