From: Thomas Graf <tgraf@suug.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org, hadi@cyberus.ca
Subject: Re: [PATCH 1/3] [PKT_SCHED]: Fix illegal memory dereferences when dumping actions
Date: Wed, 5 Jul 2006 11:09:33 +0200 [thread overview]
Message-ID: <20060705090933.GW14627@postel.suug.ch> (raw)
In-Reply-To: <44AAFCF6.9000706@trash.net>
* Patrick McHardy <kaber@trash.net> 2006-07-05 01:42
> Thomas Graf wrote:
> > @@ -834,7 +833,7 @@ tc_dump_action(struct sk_buff *skb, stru
> > a.ops = a_o;
> >
> > if (a_o->walk == NULL) {
> > - printk("tc_dump_action: %s !capable of dumping table\n", kind);
> > + printk("tc_dump_action: %s !capable of dumping table\n", a_o->kind);
> > goto rtattr_failure;
> > }
>
> Can't we just get rid of these printks? This seems like a good
> opportunity.
I agree, since this patch is definitely a stable candidate I
wanted it to stay as small as possible.
next prev parent reply other threads:[~2006-07-05 9:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 22:05 [PATCH 0/3] Action API fixes Thomas Graf
2006-07-04 22:00 ` [PATCH 1/3] [PKT_SCHED]: Fix illegal memory dereferences when dumping actions Thomas Graf
2006-07-04 23:42 ` Patrick McHardy
2006-07-05 1:49 ` jamal
2006-07-05 9:09 ` Thomas Graf [this message]
2006-07-05 1:34 ` jamal
2006-07-04 22:00 ` [PATCH 2/3] [PKT_SCHED]: Return ENOENT if action module is unavailable Thomas Graf
2006-07-05 1:40 ` jamal
2006-07-04 22:00 ` [PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping actions Thomas Graf
2006-07-05 1:47 ` jamal
2006-07-05 13:35 ` jamal
2006-07-05 13:54 ` Thomas Graf
2006-07-05 14:00 ` jamal
2006-07-06 3:47 ` [PATCH 0/3] Action API fixes David Miller
2006-07-06 12:03 ` jamal
2006-07-06 12:27 ` jamal
2006-07-06 12:45 ` Thomas Graf
2006-07-06 12:53 ` jamal
2006-07-07 6:56 ` David Miller
2006-07-07 6:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705090933.GW14627@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).