From: David Miller <davem@davemloft.net>
To: arjan@infradead.org
Cc: davej@redhat.com, akpm@osdl.org, mingo@elte.hu,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: auro deadlock
Date: Fri, 07 Jul 2006 12:09:36 -0700 (PDT) [thread overview]
Message-ID: <20060707.120936.98532669.davem@davemloft.net> (raw)
In-Reply-To: <1152295989.3111.116.camel@laptopd505.fenrus.org>
From: Arjan van de Ven <arjan@infradead.org>
Date: Fri, 07 Jul 2006 20:13:09 +0200
> Now a question for netdev: what is the interrupt-or-softirq rules for
> the sk_receive_queue.lock?
>
> Anyway, the patch below fixes this deadlock; it may or may not be the
> correct solution depending on the netdev answer, but the deadlock is
> gone ;)
The lockdep fixes are starting to cause us to go in and start adding
hard IRQ protection to many socket layer objects and I want this
thinking to end quickly :)
The netlink wireless fix is another example of this, but I accept the
temporary fix for that one for the time being.
To reiterate, nothing socket or SKB level should be taking anything
deeper than software IRQ locking.
If drivers manage local SKB queues in hard IRQ context, they need to
use a seperate lockdep identifier for that queue's lock.
next prev parent reply other threads:[~2006-07-07 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 17:19 e100 lockdep irq lock inversion Dave Jones
2006-07-07 18:13 ` auro deadlock (was Re: e100 lockdep irq lock inversion.) Arjan van de Ven
2006-07-07 19:09 ` David Miller [this message]
2006-07-07 19:39 ` auro deadlock Arjan van de Ven
2006-07-10 6:59 ` Ingo Molnar
2006-07-08 3:06 ` auro deadlock (was Re: e100 lockdep irq lock inversion.) Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060707.120936.98532669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).