From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org
Subject: Re: [patch 7/9] 8139cp.c printk fix
Date: Fri, 7 Jul 2006 00:54:14 -0700 [thread overview]
Message-ID: <20060707005414.8075b51c.akpm@osdl.org> (raw)
In-Reply-To: <44AE0F6D.80400@garzik.org>
On Fri, 07 Jul 2006 03:38:21 -0400
Jeff Garzik <jeff@garzik.org> wrote:
> akpm@osdl.org wrote:
> > From: Andrew Morton <akpm@osdl.org>
> >
> > drivers/net/8139cp.c: In function 'cp_init_one':
> > drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'resource_size_t'
> > drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'resource_size_t'
> >
> >
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
> > ---
> >
> > drivers/net/8139cp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -puN drivers/net/8139cp.c~8139cp-printk-fix drivers/net/8139cp.c
> > --- a/drivers/net/8139cp.c~8139cp-printk-fix
> > +++ a/drivers/net/8139cp.c
> > @@ -1916,7 +1916,7 @@ static int cp_init_one (struct pci_dev *
> > regs = ioremap(pciaddr, CP_REGS_SIZE);
> > if (!regs) {
> > rc = -EIO;
> > - dev_err(&pdev->dev, "Cannot map PCI MMIO (%lx@%lx)\n",
> > + dev_err(&pdev->dev, "Cannot map PCI MMIO (%Lx@%Lx)\n",
> > (unsigned long long)pci_resource_len(pdev, 1),
> > (unsigned long long)pciaddr);
>
> should be %llx if I'm not mistaken... (looks like a merge screwup on my
> part)
%llx == %Lx (doesn't it?)
It saves a byte ;)
prev parent reply other threads:[~2006-07-07 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 6:58 [patch 7/9] 8139cp.c printk fix akpm
2006-07-07 7:38 ` Jeff Garzik
2006-07-07 7:54 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060707005414.8075b51c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).