* [PATCH] net/core/dev printk message priority
@ 2006-07-07 23:41 Stephen Hemminger
2006-07-07 23:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2006-07-07 23:41 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
The printk's in the network device interface code should all be tagged with
severity.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- a/net/core/dev.c 2006-07-07 13:02:31.000000000 -0700
+++ b/net/core/dev.c 2006-07-07 16:28:22.000000000 -0700
@@ -1727,7 +1727,7 @@
if (dev->qdisc_ingress) {
__u32 ttl = (__u32) G_TC_RTTL(skb->tc_verd);
if (MAX_RED_LOOP < ttl++) {
- printk("Redir loop detected Dropping packet (%s->%s)\n",
+ printk(KERN_WARNING "Redir loop detected Dropping packet (%s->%s)\n",
skb->input_dev->name, skb->dev->name);
return TC_ACT_SHOT;
}
@@ -2922,7 +2922,7 @@
/* Fix illegal SG+CSUM combinations. */
if ((dev->features & NETIF_F_SG) &&
!(dev->features & NETIF_F_ALL_CSUM)) {
- printk("%s: Dropping NETIF_F_SG since no checksum feature.\n",
+ printk(KERN_NOTICE "%s: Dropping NETIF_F_SG since no checksum feature.\n",
dev->name);
dev->features &= ~NETIF_F_SG;
}
@@ -2930,7 +2930,7 @@
/* TSO requires that SG is present as well. */
if ((dev->features & NETIF_F_TSO) &&
!(dev->features & NETIF_F_SG)) {
- printk("%s: Dropping NETIF_F_TSO since no SG feature.\n",
+ printk(KERN_NOTICE "%s: Dropping NETIF_F_TSO since no SG feature.\n",
dev->name);
dev->features &= ~NETIF_F_TSO;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/core/dev printk message priority
2006-07-07 23:41 [PATCH] net/core/dev printk message priority Stephen Hemminger
@ 2006-07-07 23:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-07-07 23:54 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@osdl.org>
Date: Fri, 7 Jul 2006 16:41:04 -0700
> The printk's in the network device interface code should all be tagged with
> severity.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-07 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-07 23:41 [PATCH] net/core/dev printk message priority Stephen Hemminger
2006-07-07 23:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).