netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Chan <mchan@broadcom.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
Date: Fri, 7 Jul 2006 16:16:58 -0400	[thread overview]
Message-ID: <20060707201653.GE22636@tuxdriver.com> (raw)
In-Reply-To: <1551EAE59135BE47B544934E30FC4FC041BD9B@NT-IRVA-0751.brcm.ad.broadcom.com>

On Fri, Jul 07, 2006 at 12:51:35PM -0700, Michael Chan wrote:
> John W. Linville wrote:
> 
> > Add the AMD 8131 bridge to the list of chipsets that reorder writes.
> > 
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> 
> Hi John,
> 
> The latest tg3 driver in 2.6.18 has a recovery mechanism to detect
> and recover from this kind of reordering problem.  I suppose we can
> add this chipset now if we're reasonably sure that it is reordering
> MMIO.  But it will be nice to actually see the recovery mechanism in
> action catching this chipset.

Obviously it is between you and Dave to decide what is best.  We are
carrying this patch in RHEL4 at the moment, so I didn't want to hold
it back from upstream.  If you think you have a better solution then
"it's on you"... :-)

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2006-07-07 20:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-07 19:51 [PATCH] tg3: add amd8131 to "write reorder" chipsets Michael Chan
2006-07-07 20:16 ` John W. Linville [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-07-08  0:49 Michael Chan
2006-07-07 21:22 Michael Chan
2006-07-07 23:57 ` David Miller
2006-07-07 18:58 John W. Linville
2006-07-07 19:12 ` David Miller
2006-07-07 19:21   ` John W. Linville
2006-07-07 20:21   ` Auke Kok
2006-07-07 20:57     ` David Miller
2006-07-08 20:29 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060707201653.GE22636@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).