Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

[David Miller <davem@davemloft.net>]

From: Christoph Hellwig <hch@lst.de>
Date: Sat, 8 Jul 2006 12:48:12 +0200

> My plan is to give dev_alloc_skb a struct netdevice * argument and
> introduce a alloc_netdev_node so the driver can tell what node the
> device is on.  This gives a significant speedup for cell.  I already
> have this implemented in fact but only converted a handfull of drivers.
> 
> Does this approach sound okay?

I do not think it is feasible to add a netdevice argument to
such a widely used interface.

I would instead recommend that you add a new interface, and
we convert drivers gradually.

That netdevice argument is useful for other things.  For example,
you can use it to apply a per-netdev random memory allocation
failure setting, to test the robustness of drivers.  I came up
with that idea something like 7 years ago but never got around
to doing it :)