From: Thomas Graf <tgraf@suug.ch>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PKT_SCHED]: act_api: Fix module leak while flushing actions
Date: Sun, 9 Jul 2006 21:57:34 +0200 [thread overview]
Message-ID: <20060709195734.GP14627@postel.suug.ch> (raw)
In-Reply-To: <20060709.113858.01310628.davem@davemloft.net>
* David Miller <davem@davemloft.net> 2006-07-09 11:38
> From: Thomas Graf <tgraf@suug.ch>
> Date: Sun, 9 Jul 2006 16:20:43 +0200
>
> > Module reference needs to be given back if message header
> > construction fails.
> >
> > Signed-off-by: Thomas Graf <tgraf@suug.ch>
>
> Applied, thanks Thomas.
>
> This reminds me of something, not only are non-networking developers
> getting tripped up constantly about these magic code labels referenced
> from the netlink macros, they are tripping us up as well.
>
> I really think it's time, at a minimum, to explicitly mention the
> labels as an argument to the macros, or something like that.
>
> I'll try to cons something up when I get a chance. The current
> situation is too error prone.
I agree, that's why the new netlink api offers label free
methods. The transformation patches for 2.6.19 converting
all netlink users to use the new api will resolved these
issues.
next prev parent reply other threads:[~2006-07-09 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-09 14:20 [PKT_SCHED]: act_api: Fix module leak while flushing actions Thomas Graf
2006-07-09 18:38 ` David Miller
2006-07-09 19:57 ` Thomas Graf [this message]
2006-07-10 1:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060709195734.GP14627@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).