From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: brian.haley@hp.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: order addresses by scope
Date: Mon, 10 Jul 2006 15:26:24 -0700 (PDT) [thread overview]
Message-ID: <20060710.152624.14224431.davem@davemloft.net> (raw)
In-Reply-To: <20060710.181816.38918735.yoshfuji@linux-ipv6.org>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Mon, 10 Jul 2006 18:18:16 -0400 (EDT)
> In article <20060710.150045.128593827.davem@davemloft.net> (at Mon, 10 Jul 2006 15:00:45 -0700 (PDT)), David Miller <davem@davemloft.net> says:
>
> > > If IPv6 addresses are ordered by scope, then ipv6_dev_get_saddr() can
> > > break-out of the device addr_list for() loop when the candidate source
> > > address scope is less than the destination address scope.
> > >
> > > Signed-off-by: Brian Haley <brian.haley@hp.com>
> >
> > This patch looks fine to me, it's an optimization and not a
> > correctness issue.
> >
> > But I'd like an ACK from an ipv6 developer, such as Yoshifuji, before
> > adding this patch.
>
> I agree, too.
> Note: People should not depend on the order of addresses.
>
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Thank you for reviewing, patch applied.
prev parent reply other threads:[~2006-07-10 22:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-09 18:14 [PATCH] ipv6: order addresses by scope Brian Haley
2006-07-10 22:00 ` David Miller
2006-07-10 22:18 ` YOSHIFUJI Hideaki / 吉藤英明
2006-07-10 22:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710.152624.14224431.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brian.haley@hp.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).