netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: linville@tuxdriver.com
Cc: Jiri Benc <jbenc@suse.cz>,
	netdev@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] d80211: make sleeping in hw->config possible
Date: Mon, 10 Jul 2006 01:04:52 +0200	[thread overview]
Message-ID: <200607100104.53006.mb@bu3sch.de> (raw)
In-Reply-To: <200607092047.57256.mb@bu3sch.de>

On Sunday 09 July 2006 20:47, you wrote:
> ===================================================================
> --- wireless-dev-dscapeports.orig/net/d80211/ieee80211.c	2006-06-17 21:26:10.000000000 +0200
> +++ wireless-dev-dscapeports/net/d80211/ieee80211.c	2006-07-09 20:01:42.000000000 +0200
> @@ -4327,8 +4327,7 @@
>  		del_timer_sync(&local->rate_limit_timer);
>  	if (local->stat_time)
>  		del_timer_sync(&local->stat_timer);
> -	if (local->scan_timer.data)
> -		del_timer_sync(&local->scan_timer);
> +	cancel_rearming_delayed_work(&local->scan_work);
>  	ieee80211_rx_bss_list_deinit(dev);
>  
>  	rtnl_lock();

There seems to be a problem. It sometimes loops inside of
cancel_rearming_delayed_work forever. So I tried to fix it like this:
	if (local->scan_work.data)
		cancel_rearming_delayed_work(&local->scan_work);
This fixes the case where we don't scan (have no STA), so don't
initialize the work struct.

But it still loops infinite, sometimes.
Any suggestions?

-- 
Greetings Michael.

      parent reply	other threads:[~2006-07-09 23:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-09 18:47 [PATCH] d80211: make sleeping in hw->config possible Michael Buesch
2006-07-09 21:18 ` Ivo Van Doorn
2006-07-09 23:04 ` Michael Buesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607100104.53006.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=jbenc@suse.cz \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).