* [NETROM] Drop lock before calling nr_destroy_socket
@ 2006-07-10 23:25 Ralf Baechle
2006-07-11 3:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2006-07-10 23:25 UTC (permalink / raw)
To: David S. Miller, netdev, linux-hams
nr_destroy_socket takes the socket lock itself so it should better be
called with the socket unlocked.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
diff --git a/net/netrom/nr_timer.c b/net/netrom/nr_timer.c
index 75b72d3..ddba1c1 100644
--- a/net/netrom/nr_timer.c
+++ b/net/netrom/nr_timer.c
@@ -138,8 +138,8 @@ static void nr_heartbeat_expiry(unsigned
if (sock_flag(sk, SOCK_DESTROY) ||
(sk->sk_state == TCP_LISTEN && sock_flag(sk, SOCK_DEAD))) {
sock_hold(sk);
- nr_destroy_socket(sk);
bh_unlock_sock(sk);
+ nr_destroy_socket(sk);
sock_put(sk);
return;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [NETROM] Drop lock before calling nr_destroy_socket
2006-07-10 23:25 [NETROM] Drop lock before calling nr_destroy_socket Ralf Baechle
@ 2006-07-11 3:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-07-11 3:21 UTC (permalink / raw)
To: ralf; +Cc: netdev, linux-hams
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 11 Jul 2006 00:25:45 +0100
> nr_destroy_socket takes the socket lock itself so it should better be
> called with the socket unlocked.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Applied, thanks Ralf.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-11 3:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-10 23:25 [NETROM] Drop lock before calling nr_destroy_socket Ralf Baechle
2006-07-11 3:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).