netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ravinandan.arakali@neterion.com
Cc: mchan@broadcom.com, herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH]NET: Add ECN support for TSO
Date: Tue, 11 Jul 2006 18:51:31 -0700 (PDT)	[thread overview]
Message-ID: <20060711.185131.10796208.davem@davemloft.net> (raw)
In-Reply-To: <002201c6a554$e6af4580$4710100a@pc.s2io.com>

From: "Ravinandan Arakali" <ravinandan.arakali@neterion.com>
Date: Tue, 11 Jul 2006 18:45:48 -0700

> tk = tcp_sk(skb->sk);
> if (tk->ecn_flags & TCP_ECN_OK)
>    /* Check CE, ECE, CWR etc */
> 
> I find that skb->sk is NULL. Is this the correct way to check the
> per-session
> ECN capability ? Why is skb->sk NULL ?

On receive?  There is no reason for skb->sk to be anything other than
NULL on receive, the networking stack hasn't even seen the packet yet.
Only the driver has seen the skb.

  reply	other threads:[~2006-07-12  1:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-08  1:01 [PATCH]NET: Add ECN support for TSO Michael Chan
2006-07-08 20:32 ` David Miller
2006-07-12  1:45   ` Ravinandan Arakali
2006-07-12  1:51     ` David Miller [this message]
2006-07-13 17:26   ` Ravinandan Arakali
  -- strict thread matches above, loose matches on Subject: below --
2006-07-14 16:12 Dan Reader
2006-07-26 19:40 ` Michael Chan
2006-07-13 19:35 Michael Chan
2006-07-14  5:03 ` David Miller
2006-07-12  4:53 Michael Chan
2006-07-12  6:11 ` David Miller
2006-07-12 17:15   ` Ravinandan Arakali
2006-07-07 20:57 Michael Chan
2006-07-07 21:59 ` David Miller
2006-07-07 22:52   ` David Miller
2006-06-28  3:06 Michael Chan
2006-06-28  3:10 ` Herbert Xu
2006-06-28  3:40   ` Michael Chan
2006-06-28  3:48     ` Herbert Xu
2006-06-28  4:37       ` Michael Chan
2006-06-28  4:42         ` Herbert Xu
2006-06-28  4:54           ` Michael Chan
2006-06-28  4:57             ` Herbert Xu
2006-06-29 19:30         ` David Miller
2006-07-07 18:56 ` Ravinandan Arakali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060711.185131.10796208.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=ravinandan.arakali@neterion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).