From: Michael Buesch <mb@bu3sch.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linville@tuxdriver.com, jbenc@suse.cz, netdev@vger.kernel.org,
bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] d80211: make sleeping in hw->config possible #2
Date: Tue, 11 Jul 2006 12:12:53 +0200 [thread overview]
Message-ID: <200607111212.53730.mb@bu3sch.de> (raw)
In-Reply-To: <20060711023100.6d117264.akpm@osdl.org>
On Tuesday 11 July 2006 11:31, you wrote:
> On Tue, 11 Jul 2006 11:11:27 +0200
> Michael Buesch <mb@bu3sch.de> wrote:
>
> > But I think the following is also broken in the old code:
> > A wq is not pending anymore, but just executing (before it reschedules itself).
> > I think that would also loop forever. I don't think that's what we want.
> > Because we can't really keep track of _this_.
>
> The present implementation assumes that the handler will re-arm itself.
>
> I agree that extending that makes sense. But beware that it's easy to
> leave subtle holes in this logic. Needs careful thought to get right.
Yeah, as I said. There is still a race.
Should I redo the patch to fix it?
--
Greetings Michael.
next prev parent reply other threads:[~2006-07-11 10:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 22:54 [PATCH] d80211: make sleeping in hw->config possible #2 Michael Buesch
2006-07-11 4:25 ` Andrew Morton
2006-07-11 9:11 ` Michael Buesch
2006-07-11 9:31 ` Andrew Morton
2006-07-11 10:12 ` Michael Buesch [this message]
2006-07-12 16:53 ` Jiri Benc
2006-07-12 20:34 ` Michael Buesch
2006-07-18 16:57 ` [RFC, RFT] " Jiri Benc
[not found] ` <20060718185711.21aaf55b-IhiK2ZEFs2oCVLCxKZUutA@public.gmane.org>
2006-07-18 17:36 ` Michael Buesch
2006-07-18 17:58 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607111212.53730.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@osdl.org \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).