* [ROSE] lockdep: fix false positive
@ 2006-07-11 22:13 Ralf Baechle
2006-07-12 9:42 ` Ingo Molnar
2006-07-12 20:26 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ralf Baechle @ 2006-07-11 22:13 UTC (permalink / raw)
To: David S. Miller, netdev, Molnar Ingo, Arjan van de Ven
ROSE network devices are virtual network devices encapsulating ROSE
frames into AX.25 which will be sent through an AX.25 device, so form a
special "super class" of normal net devices; split their locks off into
a separate class since they always nest.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
net/rose/af_rose.c | 9 +++++++++
1 file changed, 9 insertions(+)
Index: linux-net/net/rose/af_rose.c
===================================================================
--- linux-net.orig/net/rose/af_rose.c 2006-07-10 01:35:09.000000000 +0100
+++ linux-net/net/rose/af_rose.c 2006-07-11 22:01:37.000000000 +0100
@@ -67,6 +67,14 @@ static struct proto_ops rose_proto_ops;
ax25_address rose_callsign;
/*
+ * ROSE network devices are virtual network devices encapsulating ROSE
+ * frames into AX.25 which will be sent through an AX.25 device, so form a
+ * special "super class" of normal net devices; split their locks off into a
+ * separate class since they always nest.
+ */
+static struct lock_class_key rose_netdev_xmit_lock_key;
+
+/*
* Convert a ROSE address into text.
*/
const char *rose2asc(const rose_address *addr)
@@ -1515,6 +1523,7 @@ static int __init rose_proto_init(void)
free_netdev(dev);
goto fail;
}
+ lockdep_set_class(&dev->_xmit_lock, &rose_netdev_xmit_lock_key);
dev_rose[i] = dev;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ROSE] lockdep: fix false positive
2006-07-11 22:13 [ROSE] lockdep: fix false positive Ralf Baechle
@ 2006-07-12 9:42 ` Ingo Molnar
2006-07-12 20:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2006-07-12 9:42 UTC (permalink / raw)
To: Ralf Baechle; +Cc: David S. Miller, netdev, Arjan van de Ven
* Ralf Baechle <ralf@linux-mips.org> wrote:
> ROSE network devices are virtual network devices encapsulating ROSE
> frames into AX.25 which will be sent through an AX.25 device, so form a
> special "super class" of normal net devices; split their locks off into
> a separate class since they always nest.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
thanks,
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ROSE] lockdep: fix false positive
2006-07-11 22:13 [ROSE] lockdep: fix false positive Ralf Baechle
2006-07-12 9:42 ` Ingo Molnar
@ 2006-07-12 20:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2006-07-12 20:26 UTC (permalink / raw)
To: ralf; +Cc: netdev, mingo, arjan
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 11 Jul 2006 23:13:57 +0100
> ROSE network devices are virtual network devices encapsulating ROSE
> frames into AX.25 which will be sent through an AX.25 device, so form a
> special "super class" of normal net devices; split their locks off into
> a separate class since they always nest.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-12 20:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-11 22:13 [ROSE] lockdep: fix false positive Ralf Baechle
2006-07-12 9:42 ` Ingo Molnar
2006-07-12 20:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).