From: David Miller <davem@davemloft.net>
To: akpm@osdl.org
Cc: khc@pm.waw.pl, jeff@garzik.org, netdev@vger.kernel.org,
paulkf@microgate.com
Subject: Re: [PATCH] WAN: converting generic HDLC to use netif_dormant*()
Date: Thu, 13 Jul 2006 21:18:58 -0700 (PDT) [thread overview]
Message-ID: <20060713.211858.15263760.davem@davemloft.net> (raw)
In-Reply-To: <20060713194504.f6c97d47.akpm@osdl.org>
From: Andrew Morton <akpm@osdl.org>
Date: Thu, 13 Jul 2006 19:45:04 -0700
> On Wed, 12 Jul 2006 13:46:32 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Krzysztof Halasa <khc@pm.waw.pl>
> > Date: Tue, 11 Jul 2006 23:18:45 +0200
> >
> > > This patch converts generic HDLC (and WAN drivers using it) from
> > > hdlc_set_carrier() to netif_dormant*() interface.
> > > WAN hardware drivers should now use netif_carrier_on|off() like
> > > other network drivers.
> > >
> > > Please apply. Thanks.
> > >
> > > Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
> >
> > Applied.
>
> Broken ;)
>
> WARNING: "hdlc_set_carrier" [drivers/char/synclinkmp.ko] undefined!
> WARNING: "hdlc_set_carrier" [drivers/char/synclink_gt.ko] undefined!
> WARNING: "hdlc_set_carrier" [drivers/char/synclink.ko] undefined!
> WARNING: "hdlc_set_carrier" [drivers/char/pcmcia/synclink_cs.ko] undefined!
Krzysztof please provide a fix for this, this function you added
calls to does not exist anywhere, which suggests you either produced
a patch against a different tree than the current one or you didn't
even compile test this patch.
Thanks.
next prev parent reply other threads:[~2006-07-14 4:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-11 21:18 [PATCH] WAN: converting generic HDLC to use netif_dormant*() Krzysztof Halasa
2006-07-12 20:46 ` David Miller
2006-07-14 2:45 ` Andrew Morton
2006-07-14 4:18 ` David Miller [this message]
2006-07-16 12:07 ` Krzysztof Halasa
2006-07-16 12:17 ` [PATCH] WAN: Added missing netif_dormant_off() to generic HDLC Krzysztof Halasa
2006-07-17 1:58 ` David Miller
2006-07-16 12:19 ` [PATCH] WAN: Cosmetic changes to N2 and C101 drivers Krzysztof Halasa
2006-07-17 1:59 ` David Miller
2006-07-16 12:23 ` [PATCH] WAN: Converted synclink drivers to use netif_carrier_*() Krzysztof Halasa
2006-07-17 2:00 ` David Miller
2006-07-17 20:34 ` Generic HDLC changes, Was: " Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060713.211858.15263760.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox