netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [SLHC 3/4] Remove useless casts
@ 2006-07-13 11:12 Ralf Baechle
  2006-07-13 17:09 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2006-07-13 11:12 UTC (permalink / raw)
  To: David S. Miller, netdev, Jeff Garzik

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

---
 drivers/net/slhc.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Index: linux-net/drivers/net/slhc.c
===================================================================
--- linux-net.orig/drivers/net/slhc.c	2006-07-10 01:35:51.000000000 +0100
+++ linux-net/drivers/net/slhc.c	2006-07-10 01:35:56.000000000 +0100
@@ -94,14 +94,13 @@ slhc_init(int rslots, int tslots)
 	register struct cstate *ts;
 	struct slcompress *comp;
 
-	comp = (struct slcompress *)kzalloc(sizeof(struct slcompress),
-					    GFP_KERNEL);
+	comp = kzalloc(sizeof(struct slcompress), GFP_KERNEL);
 	if (! comp)
 		goto out_fail;
 
 	if ( rslots > 0  &&  rslots < 256 ) {
 		size_t rsize = rslots * sizeof(struct cstate);
-		comp->rstate = (struct cstate *) kzalloc(rsize, GFP_KERNEL);
+		comp->rstate = kzalloc(rsize, GFP_KERNEL);
 		if (! comp->rstate)
 			goto out_free;
 		comp->rslot_limit = rslots - 1;
@@ -109,7 +108,7 @@ slhc_init(int rslots, int tslots)
 
 	if ( tslots > 0  &&  tslots < 256 ) {
 		size_t tsize = tslots * sizeof(struct cstate);
-		comp->tstate = (struct cstate *) kzalloc(tsize, GFP_KERNEL);
+		comp->tstate = kzalloc(tsize, GFP_KERNEL);
 		if (! comp->tstate)
 			goto out_free2;
 		comp->tslot_limit = tslots - 1;
@@ -138,9 +137,9 @@ slhc_init(int rslots, int tslots)
 	return comp;
 
 out_free2:
-	kfree((unsigned char *)comp->rstate);
+	kfree(comp->rstate);
 out_free:
-	kfree((unsigned char *)comp);
+	kfree(comp);
 out_fail:
 	return NULL;
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [SLHC 3/4] Remove useless casts
  2006-07-13 11:12 [SLHC 3/4] Remove useless casts Ralf Baechle
@ 2006-07-13 17:09 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2006-07-13 17:09 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: David S. Miller, netdev, Jeff Garzik

On Thu, Jul 13, 2006 at 12:12:53PM +0100, Ralf Baechle wrote:
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

oops, foget my previous mail :)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-07-13 17:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-13 11:12 [SLHC 3/4] Remove useless casts Ralf Baechle
2006-07-13 17:09 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).