From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: [2.6 patch] net/core/user_dma.c should #include Date: Sat, 15 Jul 2006 02:36:17 +0200 Message-ID: <20060715003617.GL3633@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: Received: from mailout.stusta.mhn.de ([141.84.69.5]:34569 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1945942AbWGOAgS (ORCPT ); Fri, 14 Jul 2006 20:36:18 -0400 To: Chris Leech Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Every file should #include the headers containing the prototypes for its global functions. Especially in cases like this one where gcc can tell us through a compile error that the prototype was wrong... Signed-off-by: Adrian Bunk --- include/net/netdma.h | 2 +- net/core/user_dma.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.18-rc1-mm2-full/include/net/netdma.h.old 2006-07-15 00:52:38.000000000 +0200 +++ linux-2.6.18-rc1-mm2-full/include/net/netdma.h 2006-07-15 00:52:43.000000000 +0200 @@ -37,7 +37,7 @@ } int dma_skb_copy_datagram_iovec(struct dma_chan* chan, - const struct sk_buff *skb, int offset, struct iovec *to, + struct sk_buff *skb, int offset, struct iovec *to, size_t len, struct dma_pinned_list *pinned_list); #endif /* CONFIG_NET_DMA */ --- linux-2.6.18-rc1-mm2-full/net/core/user_dma.c.old 2006-07-14 21:59:37.000000000 +0200 +++ linux-2.6.18-rc1-mm2-full/net/core/user_dma.c 2006-07-14 21:59:50.000000000 +0200 @@ -29,6 +29,7 @@ #include #include /* for BUG_TRAP */ #include +#include #define NET_DMA_DEFAULT_COPYBREAK 4096