From: Paul Moore <paul.moore@hp.com>
To: James Morris <jmorris@namei.org>
Cc: netdev@vger.kernel.org, selinux@tycho.nsa.gov,
"David S. Miller" <davem@davemloft.net>,
sds@epoch.ncsc.mil, pratt@argus-systems.com
Subject: Re: [PATCH 2/7] NetLabel: core network changes
Date: Sat, 15 Jul 2006 10:48:02 -0400 [thread overview]
Message-ID: <200607151048.02921.paul.moore@hp.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0607141933170.18747@d.namei>
On Friday 14 July 2006 7:34 pm, James Morris wrote:
> On Fri, 14 Jul 2006, paul.moore@hp.com wrote:
> > +static inline void netlbl_put_hdr(unsigned char *buffer,
> > + const u32 msg_type,
> > + const u16 msg_len,
> > + const u16 msg_flags,
> > + const u32 msg_pid,
> > + const u32 msg_seq)
>
> Why are these parameters marked const? Seems to be common throughout the
> code.
>
I saw similar things in the kernel, but it looks like I was looking at
older, "less desirable" sections of code. Since it looks like you are still
churning through the patchset I'll hold off on submitting a new version based
on your comments until Monday.
Once again, thanks for your comments and patience.
--
paul moore
linux security @ hp
next prev parent reply other threads:[~2006-07-15 14:49 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-14 18:57 [PATCH 0/7] Latest NetLabel patch for 2.6.19 paul.moore
2006-07-14 18:57 ` [PATCH 1/7] NetLabel: documentation paul.moore
2006-07-14 18:57 ` [PATCH 2/7] NetLabel: core network changes paul.moore
2006-07-14 23:34 ` James Morris
2006-07-14 23:36 ` David Miller
2006-07-15 14:48 ` Paul Moore [this message]
2006-07-14 18:57 ` [PATCH 3/7] NetLabel: CIPSOv4 engine paul.moore
2006-07-14 23:56 ` James Morris
2006-07-15 2:03 ` James Morris
2006-07-15 14:59 ` Paul Moore
2006-07-16 16:10 ` Paul Moore
2006-07-17 1:12 ` David Miller
2006-07-17 2:42 ` Paul Moore
2006-07-17 2:53 ` David Miller
2006-07-15 2:18 ` James Morris
2006-07-15 15:03 ` Paul Moore
2006-07-15 13:08 ` James Morris
2006-07-15 13:11 ` James Morris
2006-07-15 15:13 ` Paul Moore
2006-07-15 15:09 ` Paul Moore
2006-07-15 13:15 ` James Morris
2006-07-15 15:14 ` Paul Moore
2006-07-15 22:39 ` James Morris
2006-07-15 23:26 ` Paul Moore
2006-07-14 18:57 ` [PATCH 4/7] NetLabel: core NetLabel subsystem paul.moore
2006-07-14 18:57 ` [PATCH 5/7] NetLabel: CIPSOv4 and Unlabeled packet integration paul.moore
2006-07-14 18:57 ` [PATCH 6/7] NetLabel: SELinux support paul.moore
2006-07-14 18:57 ` [PATCH 7/7] NetLabel: tie NetLabel into the Kconfig system paul.moore
-- strict thread matches above, loose matches on Subject: below --
2006-07-17 15:52 [PATCH 0/7] Updated patchset w/James' comments paul.moore
2006-07-17 15:52 ` [PATCH 2/7] NetLabel: core network changes paul.moore
2006-07-28 7:55 ` David Miller
2006-07-28 18:45 ` Paul Moore
2006-07-28 19:55 ` David Miller
2006-07-28 11:24 ` Thomas Graf
2006-07-28 17:58 ` Paul Moore
2006-07-28 18:12 ` Thomas Graf
2006-07-28 18:39 ` Paul Moore
2006-07-28 18:58 ` Thomas Graf
2006-07-28 19:08 ` Paul Moore
2006-07-28 19:43 ` Evgeniy Polyakov
2006-07-28 19:58 ` David Miller
2006-07-28 20:09 ` Paul Moore
2006-07-28 20:56 ` David Miller
2006-07-28 20:59 ` Paul Moore
2006-07-29 16:34 Venkat Yekkirala
2006-07-29 21:03 ` Paul Moore
2006-07-31 12:43 Venkat Yekkirala
2006-07-31 14:16 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607151048.02921.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
--cc=pratt@argus-systems.com \
--cc=sds@epoch.ncsc.mil \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).