From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hch-jcswGhMUV9g@public.gmane.org,
irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] [IrDA] Use alloc_skb() in IrDA TX path
Date: Tue, 18 Jul 2006 15:38:31 -0700 (PDT) [thread overview]
Message-ID: <20060718.153831.22498182.davem@davemloft.net> (raw)
In-Reply-To: <20060719051331.GA3817-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
From: Samuel Ortiz <samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
Date: Wed, 19 Jul 2006 08:13:31 +0300
> As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be
> used for allocating TX sk_buff. The IrDA stack was exclusively calling
> dev_alloc_skb() on the TX path, and this patch fixes that.
>
> Signed-off-by: Samuel Ortiz <samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
Applied, thanks Samuel.
As followups it would be nice to:
1) See if any of the GFP_ATOMIC's can be moved to GFP_KERNEL.
I do understand that many of these call sites are running
in software interrupt context or are holding spinlocks and
thus must use GFP_ATOMIC.
2) Change these 64 and 128 constant sizes to something with
a name.
Thanks!
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2006-07-18 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 5:13 [PATCH] [IrDA] Use alloc_skb() in IrDA TX path Samuel Ortiz
[not found] ` <20060719051331.GA3817-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2006-07-18 22:38 ` David Miller [this message]
[not found] ` <20060718.153831.22498182.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2006-07-19 6:10 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060718.153831.22498182.davem@davemloft.net \
--to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).