From: Chris Wright <chrisw@sous-sol.org>
To: David Miller <davem@davemloft.net>
Cc: chrisw@sous-sol.org, linux-kernel@vger.kernel.org,
virtualization@lists.osdl.org, xen-devel@lists.xensource.com,
jeremy@goop.org, ak@suse.de, akpm@osdl.org,
rusty@rustcorp.com.au, zach@vmware.com, ian.pratt@xensource.com,
Christian.Limpach@cl.cam.ac.uk, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.
Date: Tue, 18 Jul 2006 14:09:50 -0700 [thread overview]
Message-ID: <20060718210950.GG2654@sequoia.sous-sol.org> (raw)
In-Reply-To: <20060718.134219.48395353.davem@davemloft.net>
* David Miller (davem@davemloft.net) wrote:
> From: Chris Wright <chrisw@sous-sol.org>
> Date: Tue, 18 Jul 2006 00:00:32 -0700
>
> > +#ifdef CONFIG_XEN_BALLOON
> > +#include <xen/balloon.h>
> > +#endif
>
> Let's put the ifdefs in xen/balloon.h not in the files
> including it.
>
> > +#ifdef CONFIG_XEN_BALLOON
> > + /* Tell the ballon driver what is going on. */
> > + balloon_update_driver_allowance(i);
> > +#endif
>
> Similarly let's define empty do-nothing functions in
> xen/balloon.h when the config option isn't set so we
> don't need to crap up the C sources with these ifdefs.
Yeah, sorry it's kept more as a reminder to me. Upstream Xen doesn't do
this, but this patchset doesn't support ballooning yet, so there just is
not xen/balloon.h in the set. When merging with upstream Xen there's
patch rejects either way, so I agree, better to just drop this since
it's just future placeholder.
thanks,
-chris
prev parent reply other threads:[~2006-07-18 21:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060718091807.467468000@sous-sol.org>
2006-07-18 7:00 ` [RFC PATCH 32/33] Add the Xen virtual network device driver Chris Wright
2006-07-18 10:27 ` Arjan van de Ven
2006-07-18 10:35 ` Keir Fraser
2006-07-18 10:42 ` Arjan van de Ven
2006-07-18 12:18 ` Dave Boutcher
2006-07-18 12:39 ` jamal
2006-07-18 13:08 ` Herbert Xu
2006-07-18 13:25 ` John Haller
2006-07-18 15:22 ` Herbert Xu
2006-07-18 15:44 ` Stephen Hemminger
2006-07-19 3:55 ` Herbert Xu
2006-07-18 20:42 ` David Miller
2006-07-18 21:09 ` Chris Wright [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060718210950.GG2654@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=ian.pratt@xensource.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).